rockchip: migrate xt-q8l-v10 uboot patches#9669
Merged
paolosabatino merged 1 commit intoarmbian:mainfrom Apr 14, 2026
Merged
Conversation
paolosabatino
requested review from
ColorfulRhino,
HeyMeco,
NicoD-SBC,
SuperKali,
Tonymac32,
amazingfate,
catalinii and
efectn
as code owners
github-actions
bot
added
size/large
Contributor
📝 WalkthroughWalkthroughThe PR reorganizes the XT-Q8L-V10 Rockchip RK3288 board U-Boot configuration from patch files to standard defconfig and device tree source files, removing two board-specific patches and adding three configuration files in standard locations. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
bot
added
Needs review
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
patch/u-boot/v2026.04/dt_uboot/rk3288-xt-q8l-v10.dts (2)
172-181: Minor: Inconsistent indentation (mixed tabs/spaces).Lines 178-179 have mixed tab and space indentation. While this doesn't affect functionality, consistent indentation improves maintainability.
✨ Suggested fix for consistent indentation
vcc_host_5v: usb-host-regulator { compatible = "regulator-fixed"; gpio = <&gpio0 14 GPIO_ACTIVE_HIGH>; regulator-name = "vcc_host_5v"; regulator-min-microvolt = <5000000>; regulator-max-microvolt = <5000000>; - regulator-boot-on; - enable-active-high; + regulator-boot-on; + enable-active-high; vin-supply = <&vcc_sys>; };🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@patch/u-boot/v2026.04/dt_uboot/rk3288-xt-q8l-v10.dts` around lines 172 - 181, The vcc_host_5v usb-host-regulator block contains mixed tabs and spaces (in the gpio and regulator-name lines) causing inconsistent indentation; update the indentation in the usb-host-regulator block (identify by label vcc_host_5v and compatible = "regulator-fixed") to match the file's prevailing style (use either all spaces or all tabs consistently), fixing the gpio = <&gpio0 14 GPIO_ACTIVE_HIGH>; and regulator-name = "vcc_host_5v"; lines to use the same indentation as the surrounding property lines.
690-698: Minor: Inconsistent property formatting.The
statusandbootph-allproperties here lack spaces around=, while other nodes in the file usestatus = "okay"with spaces.✨ Suggested fix for consistent formatting
&i2c5 { - status="okay"; - bootph-all; + status = "okay"; + bootph-all; }; &efuse { - status="okay"; - bootph-all; + status = "okay"; + bootph-all; };🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@patch/u-boot/v2026.04/dt_uboot/rk3288-xt-q8l-v10.dts` around lines 690 - 698, Update the property formatting in the &i2c5 and &efuse device tree nodes to match the file's style: change status="okay"; to status = "okay"; (keep bootph-all; as-is but ensure spacing around any = operators matches other nodes). Edit the lines in the &i2c5 and &efuse blocks so they read status = "okay"; and preserve the bootph-all property formatting consistent with the rest of the file.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@patch/u-boot/v2026.04/defconfig/xt-q8l-v10-rk3288_defconfig`:
- Line 79: Remove the Gateworks-specific Kconfig option from the RK3288 board
defconfig: delete or change CONFIG_GATEWORKS_SC=y in the
xt-q8l-v10-rk3288_defconfig to unset (remove the line or set to n) because this
enables the Gateworks System Controller driver which is irrelevant for Rockchip
RK3288; also scan for any other CONFIG_GATEWORKS_* entries and remove/unset them
to avoid accidentally enabling Gateworks drivers on this board.
---
Nitpick comments:
In `@patch/u-boot/v2026.04/dt_uboot/rk3288-xt-q8l-v10.dts`:
- Around line 172-181: The vcc_host_5v usb-host-regulator block contains mixed
tabs and spaces (in the gpio and regulator-name lines) causing inconsistent
indentation; update the indentation in the usb-host-regulator block (identify by
label vcc_host_5v and compatible = "regulator-fixed") to match the file's
prevailing style (use either all spaces or all tabs consistently), fixing the
gpio = <&gpio0 14 GPIO_ACTIVE_HIGH>; and regulator-name = "vcc_host_5v"; lines
to use the same indentation as the surrounding property lines.
- Around line 690-698: Update the property formatting in the &i2c5 and &efuse
device tree nodes to match the file's style: change status="okay"; to status =
"okay"; (keep bootph-all; as-is but ensure spacing around any = operators
matches other nodes). Edit the lines in the &i2c5 and &efuse blocks so they read
status = "okay"; and preserve the bootph-all property formatting consistent with
the rest of the file.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 1c610be0-4b95-4ebd-b6b1-e1d83dc54846
📒 Files selected for processing (5)
patch/u-boot/v2026.04/board_xt-q8l-v10/xt-q8l-v10-defconfig.patchpatch/u-boot/v2026.04/board_xt-q8l-v10/xt-q8l-v10-device-tree.patchpatch/u-boot/v2026.04/defconfig/xt-q8l-v10-rk3288_defconfigpatch/u-boot/v2026.04/dt_uboot/rk3288-xt-q8l-v10-u-boot.dtsipatch/u-boot/v2026.04/dt_uboot/rk3288-xt-q8l-v10.dts
💤 Files with no reviewable changes (2)
- patch/u-boot/v2026.04/board_xt-q8l-v10/xt-q8l-v10-defconfig.patch
- patch/u-boot/v2026.04/board_xt-q8l-v10/xt-q8l-v10-device-tree.patch
igorpecovnik
approved these changes
Apr 14, 2026
Contributor
|
✅ This PR has been reviewed and approved — all set for merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
No fancy things, just minor tidy up. Following another PR, this PR removes u-boot patches for CSC board xt-q8l-v10 and uses
defconfiganddt_ubootdirectories.How Has This Been Tested?
Checklist:
Summary by CodeRabbit
Release Notes