fix: preserve location in RetryAmbiguousDateWithSwap retry#169
Open
Yanhu007 wants to merge 1 commit intoaraddon:masterfrom
Open
fix: preserve location in RetryAmbiguousDateWithSwap retry#169Yanhu007 wants to merge 1 commit intoaraddon:masterfrom
Yanhu007 wants to merge 1 commit intoaraddon:masterfrom
Conversation
When RetryAmbiguousDateWithSwap retries parsing after a "month out
of range" error, it called parseTime with time.Local instead of the
original location parameter. This causes inconsistent timezones:
ParseAny("21/09/2010", RetryAmbiguousDateWithSwap(true))
→ 2010-09-21 00:00:00 +0200 CEST (uses time.Local in retry)
ParseAny("09/21/2010", RetryAmbiguousDateWithSwap(true))
→ 2010-09-21 00:00:00 +0000 UTC (no retry needed)
Fix: pass the original loc parameter to the retry parseTime call
instead of time.Local, ensuring consistent timezone handling.
Fixes araddon#161
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #161
Problem
When
RetryAmbiguousDateWithSwapretries parsing after a "month out of range" error, it callsparseTimewithtime.Localinstead of the originallocparameter. This causes timezone inconsistency:Fix
One-line change: pass
loc(the original location parameter) instead oftime.Localto the retryparseTimecall.All existing tests pass.