Cleanup serving stale while origin server down#13083
Open
masaori335 wants to merge 1 commit intoapache:masterfrom
Open
Cleanup serving stale while origin server down#13083masaori335 wants to merge 1 commit intoapache:masterfrom
masaori335 wants to merge 1 commit intoapache:masterfrom
Conversation
masaori335
force-pushed
the
asf-master-stale-while-down
branch
from
bfc2ef4 to
4eaac41
Compare
masaori335
force-pushed
the
asf-master-stale-while-down
branch
from
4eaac41 to
c198907
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HttpTransact::HandleCacheOpenReadHittry to return stale contents by checkingis_server_negative_cached(s), but actually, this is dead code. Because when all origin servers are marked down,HttpTransact::OSDNSLookupserves stale contents.This PR marked as draft because new AuTest depends on #13069.(update: this is ready)