Make sure string metrics are dumped in RecDumpRecords#13074
Merged
cmcfarlen merged 1 commit intoapache:masterfrom Apr 15, 2026
Merged
Make sure string metrics are dumped in RecDumpRecords#13074cmcfarlen merged 1 commit intoapache:masterfrom
cmcfarlen merged 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
[approve ci autest 1] |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the records dump path so plugin string metrics (e.g., used by stats_over_http) are included when RecDumpRecords / TSRecordDump enumerates metrics.
Changes:
- Extend
RecDumpRecords()to also emitts::Metrics::StaticStringentries asRECT_PLUGIN/ string data. - Add a Catch2 unit test that registers a
StaticStringmetric and asserts it appears inRecDumpRecords()output. - Wire the new unit test into the
test_recordstarget.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/records/RecCore.cc |
Adds dumping of static string metrics via StaticString::for_each() into RecDumpRecords(). |
src/records/unit_tests/test_RecDumpRecords.cc |
New unit test validating string metrics appear in RecDumpRecords() output. |
src/records/CMakeLists.txt |
Adds the new unit test source to the test_records executable. |
bneradt
approved these changes
Apr 15, 2026
cmcfarlen
added a commit
that referenced
this pull request
Apr 15, 2026
(cherry picked from commit e7e30bb)
Contributor
Author
|
Cherry-picked to 10.2.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bug was preventing string metrics from showing up in plugins like stats_over_http.