Add ByteString.endsWith and expand startsWith test coverage#2862
Open
pjfanning wants to merge 7 commits intoapache:mainfrom
Open
Add ByteString.endsWith and expand startsWith test coverage#2862pjfanning wants to merge 7 commits intoapache:mainfrom
pjfanning wants to merge 7 commits intoapache:mainfrom
Conversation
Member
Author
|
I intend to look at adding a set of JMH benchmarks. |
Agent-Logs-Url: https://github.com/pjfanning/incubator-pekko/sessions/ec49ac93-3978-458d-882a-e3a243c1b19f Co-authored-by: pjfanning <11783444+pjfanning@users.noreply.github.com>
…e loop Agent-Logs-Url: https://github.com/pjfanning/incubator-pekko/sessions/fe94910a-758a-4038-be9e-32cad79ed452 Co-authored-by: pjfanning <11783444+pjfanning@users.noreply.github.com>
50d10f7 to
4c331dc
Compare
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ByteStringhadstartsWith(Array[Byte])but noendsWithequivalent, and the existingstartsWithtests lacked edge-case coverage.New API
endsWith(bytes: Array[Byte]): Booleanadded to theByteStringbase class, mirroringstartsWithsemantics:Test improvements
startsWith: added coverage for empty byte array (alwaystrue), exact-length match, bytes longer than the string (false),ByteString1C, and emptyByteStringendsWith: full suite coveringByteString1,ByteString1C,ByteStrings(multi-segment, including cross-boundary suffix),ByteString1with internal offset, empty byte array, exact match, oversized input, and emptyByteString