GH-3468: Fix lint error which block compilation#3469
Open
Yao-MR wants to merge 1 commit intoapache:masterfrom
Open
GH-3468: Fix lint error which block compilation#3469Yao-MR wants to merge 1 commit intoapache:masterfrom
Yao-MR wants to merge 1 commit intoapache:masterfrom
Conversation
Author
|
hi. @steveloughran can you have a quick review ? |
steveloughran
approved these changes
Apr 16, 2026
Contributor
steveloughran
left a comment
steveloughran
left a comment
There was a problem hiding this comment.
LGTM.
I'm not a committer though, you'll need someone else to review it too
Contributor
|
@Yao-MR I'm afraid that the linter does not agree with your changes. What kind of error did you see locally? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Rationale for this change
The project has comment formatting issues that violate lint rules, which block compilation. This PR fixes those lint errors to allow the project to compile successfully.
2. What changes are included in this PR?
This PR contains purely code style / comment formatting adjustments across 4 Java files:
ParquetMetadataConverter.java// falls throughcomment in a switch statementDirectCodecFactory.java// todo:comment to comply with lint rulesBufferedProtocolReadToWrite.javaTType.ENUMProtocolReadToWrite.javaAll changes are strictly comment formatting corrections. No functional code was modified.
3. Are these changes tested?
Yes. The author confirmed the changes were verified through Compile and UT (Unit Tests). Since only comment formatting was changed with no logic modifications, passing compilation and unit tests provides sufficient validation.
4. Are there any user-facing changes?
No. This PR only corrects comment code style. It does not affect any APIs, functional behavior, or anything perceivable by end users.