feat(write): add MERGE & UPDATE with DataEvolutionWriter#241
Merged
JingsongLi merged 2 commits intoapache:mainfrom Apr 15, 2026
Merged
feat(write): add MERGE & UPDATE with DataEvolutionWriter#241JingsongLi merged 2 commits intoapache:mainfrom
JingsongLi merged 2 commits intoapache:mainfrom
Conversation
JingsongLi
force-pushed
the
merge-into
branch
2 times, most recently
from
de603ad to
1c52144
Compare
JingsongLi
changed the title
JingsongLi
changed the title
JingsongLi
force-pushed
the
merge-into
branch
2 times, most recently
from
0c496bc to
16c7d0a
Compare
| .with_bucket(file_range.bucket) | ||
| .with_bucket_path(file_range.bucket_path.clone()) | ||
| .with_total_buckets(file_range.total_buckets) | ||
| .with_data_files(vec![file.clone()]) |
Contributor
There was a problem hiding this comment.
At this point, _ROW_ID has already been narrowed to a single DataFileMeta, and this read only loads that file back. However, the current logical row range may span multiple files with the same first_row_id (base file + partial-column files). Upstream Java/Python paths seem to read the whole first_row_id group.
| ins.columns | ||
| .iter() | ||
| .zip(ins.value_exprs.iter()) | ||
| .map(|(col, expr)| format!("{expr} AS {col}")) |
Contributor
There was a problem hiding this comment.
This keeps the generated batch in INSERT (...) order. But the write path later reads partition/bucket fields by target schema index, not by column name, so a reordered insert list can mis-map columns on partitioned / fixed-bucket tables.
Contributor
Author
|
@littlecoder04 Thanks for the review, fixed comments and add e2e tests. |
JingsongLi
changed the title
JingsongLi
changed the title
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Brief change log
Tests
API and Format
Documentation