Warn when profile ID matches a lifecycle phase name#11926
Open
utafrali wants to merge 1 commit intoapache:masterfrom
Open
Warn when profile ID matches a lifecycle phase name#11926utafrali wants to merge 1 commit intoapache:masterfrom
utafrali wants to merge 1 commit intoapache:masterfrom
Conversation
Emit a validation warning when a profile ID matches a default Maven lifecycle phase (clean, compile, test, package, deploy, etc.). Using lifecycle phase names as profile IDs can lead to accidental phase execution when the name is misused on the command line. Closes apache#10310
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a profile ID matches a default Maven lifecycle phase name (e.g. "test", "deploy", "integration-test"), users can accidentally trigger that phase. This adds a validation warning to alert about the potential confusion.
Includes a new test case with a POM containing both phase-matching and safe profile IDs.
Closes #10310