[client] Add validation for client.scanner.log.max-poll-records and client.connect-timeout#3069
Open
Prajwal-banakar wants to merge 1 commit intoapache:mainfrom
Open
[client] Add validation for client.scanner.log.max-poll-records and client.connect-timeout#3069Prajwal-banakar wants to merge 1 commit intoapache:mainfrom
Prajwal-banakar wants to merge 1 commit intoapache:mainfrom
Conversation
…lient.connect-timeout
Contributor
Author
Contributor
fresh-borzoni
left a comment
fresh-borzoni
left a comment
There was a problem hiding this comment.
@Prajwal-banakar Ty for the PR, left some comments, PTAL
|
|
||
| public static void validateClientConfigs(Configuration conf) { | ||
| int maxPollRecords = conf.getInt(ConfigOptions.CLIENT_SCANNER_LOG_MAX_POLL_RECORDS); | ||
| if (maxPollRecords <= 0) { |
Contributor
There was a problem hiding this comment.
Shall we use validMinValue?
| } | ||
|
|
||
| long connectTimeoutMs = conf.get(ConfigOptions.CLIENT_CONNECT_TIMEOUT).toMillis(); | ||
| if (connectTimeoutMs <= 0) { |
Contributor
There was a problem hiding this comment.
mb we can have validMinDuration(conf, option, minMillis) helper to match the existing pattern?
| Configuration.fromMap( | ||
| extractPrefix(new HashMap<>(conf.toMap()), CLIENT_PREFIX + "fs.")), | ||
| null); | ||
| FlussConfigUtils.validateClientConfigs(conf); |
Contributor
There was a problem hiding this comment.
Nit: can we move FlussConfigUtils.validateClientConfigs(conf) to the very first line of the constructor, before FileSystem.initialize(...) and setupClientMetricsConfiguration()?
Right now a bad config still initializes the filesystem and sets up metrics before failing, while fail-fast is cheaper and avoids partial side effects.
|
|
||
| // connect-timeout = 0 should fail | ||
| Configuration zeroTimeoutConf = new Configuration(); | ||
| zeroTimeoutConf.set(ConfigOptions.CLIENT_CONNECT_TIMEOUT, java.time.Duration.ZERO); |
Contributor
There was a problem hiding this comment.
nit: why fully qualified name?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #3068
Add client config validation for
client.scanner.log.max-poll-recordsandclient.connect-timeoutduringFlussConnectioninitialization. Setting either of these to 0 or negative makes no practical sense — poll() would return nothing and TCP connect would time out immediately.Brief change log
validateClientConfigs()inFlussConfigUtilscoveringclient.scanner.log.max-poll-records(must be > 0) andclient.connect-timeout(must be > 0)validateClientConfigs()inFlussConnectionconstructorFlussConfigUtilsTestTests
Existing
FlussConfigUtilsTestextended withtestValidateClientConfigs()covering default validity and each invalid case.API and Format
NO
Documentation
NO