feat: Add Spark-compatible monthname function to datafusion-spark#21639
Open
JeelRajodiya wants to merge 4 commits intoapache:mainfrom
Open
feat: Add Spark-compatible monthname function to datafusion-spark#21639JeelRajodiya wants to merge 4 commits intoapache:mainfrom
monthname function to datafusion-spark#21639JeelRajodiya wants to merge 4 commits intoapache:mainfrom
Conversation
Implements `monthname(date_or_timestamp)` that returns the three-letter abbreviated month name (Jan, Feb, ..., Dec) from a date or timestamp, matching Apache Spark's behavior.
JeelRajodiya
force-pushed
the
feat/spark-monthname-function
branch
from
d13c56b to
a4228b9
Compare
Jefffrey
reviewed
Apr 16, 2026
JeelRajodiya
force-pushed
the
feat/spark-monthname-function
branch
from
d32a486 to
e066989
Compare
Jefffrey
approved these changes
Apr 17, 2026
Contributor
Jefffrey
left a comment
Jefffrey
left a comment
There was a problem hiding this comment.
Should be good to go once CI is green
Author
|
I've fixed the CI errors |
andygrove
reviewed
Apr 17, 2026
| impl SparkMonthName { | ||
| pub fn new() -> Self { | ||
| Self { | ||
| signature: Signature::exact(vec![DataType::Date32], Volatility::Immutable), |
Member
There was a problem hiding this comment.
Spark supports input types TIMESTAMP, TIMESTAMP_NTZ, DATE. Perhaps DataFusion will coerce the equivalent types, or should explicit support be added here?
andygrove
reviewed
Apr 17, 2026
Comment on lines
+100
to
+102
| # Error: wrong argument type (string without cast) | ||
| statement error Failed to coerce arguments to satisfy a call to 'monthname' function | ||
| SELECT monthname('not-a-date'); |
Member
There was a problem hiding this comment.
I think Spark returns NULL in this case if ANSI mode is disabled, which is the default prior to Spark 4.
andygrove
reviewed
Apr 17, 2026
|
|
||
| # Scalar date input | ||
| query T | ||
| SELECT monthname('2024-03-15'::DATE); |
Member
There was a problem hiding this comment.
Could you also add tests with timestamp input to show that the coercion works as expected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
The
datafusion-sparkcrate is missing themonthnamefunction. Spark'smonthname(date)returns the three-letter abbreviated month name (Jan, Feb, ..., Dec) from a date or timestamp — commonly used in Spark SQL workloads.What changes are included in this PR?
Adds
SparkMonthNametodatafusion-spark's datetime functions. It usesarrow::compute::date_part(DatePart::Month)to extract the month number and maps it to the abbreviated name. The signature accepts Timestamp types with automatic coercion from Date32/Date64.Are these changes tested?
Yes — 6 unit tests covering scalar dates, array dates with nulls, null scalars, timestamp microseconds, all 12 months, and return field nullability.
Are there any user-facing changes?
New
monthnamescalar function available when usingdatafusion-spark.