fix: support API key authentication in private mode#1521
Open
Herrtian wants to merge 1 commit intoapache:mainfrom
Open
fix: support API key authentication in private mode#1521Herrtian wants to merge 1 commit intoapache:mainfrom
Herrtian wants to merge 1 commit intoapache:mainfrom
Conversation
When LoginRequired=true, EjectUserBySiteInfo middleware only checked for session-based authentication. API key requests were rejected with 401 even when using a valid key. Now the middleware falls back to API key validation when no user session is found, allowing programmatic access to private instances.
5c3e926 to
6026d30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1508
When
LoginRequired=true(private mode), theEjectUserBySiteInfomiddleware only checked for session-based authentication (cookies). Requests with valid API keys in theAuthorizationheader were rejected with 401 Unauthorized.Change
File:
internal/base/middleware/auth.go—EjectUserBySiteInfo()When no user session is found in the context, the middleware now falls back to API key validation via
authService.AuthAPIKey()before rejecting the request. This reuses the same validation logic already used by theAuthAPIKey()middleware for MCP routes.Test plan
go build ./...compiles successfully🤖 Generated with Claude Code