Skip to content

resolve last requests mistakes#17593

Open
hougomartim wants to merge 48 commits intoandresriancho:masterfrom
hougomartim:master
Open

resolve last requests mistakes#17593
hougomartim wants to merge 48 commits intoandresriancho:masterfrom
hougomartim:master

Conversation

@hougomartim
Copy link
Copy Markdown
Contributor

@hougomartim hougomartim commented Feb 2, 2019

No description provided.

@hougomartim
Copy link
Copy Markdown
Contributor Author

hougomartim commented Feb 2, 2019

resolve the last pull request mistakes, sorry for lating, Thanks to you ./

@andresriancho
Copy link
Copy Markdown
Owner

andresriancho commented Feb 4, 2019

Still multiple bugs

andresriancho
andresriancho reviewed Feb 4, 2019
View reviewed changes
Copy link
Copy Markdown
Owner

@andresriancho andresriancho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the bugs I've found

@hougomartim
Copy link
Copy Markdown
Contributor Author

hougomartim commented Feb 8, 2019

thanks for reviews.

@hougomartim
Copy link
Copy Markdown
Contributor Author

hougomartim commented Oct 22, 2019

@andresriancho
Request a review. Thank you so much.

@andresriancho
Copy link
Copy Markdown
Owner

andresriancho commented Oct 28, 2019

This change looks much better than before.

Something I noticed was that the change also impacts the sqlmap source code we embed in w3af/plugins/attack/db/sqlmap. The next time I merge the latest sqlmap into that directory in w3af, those changes will be overwritten / generate lots of merge conflicts. Please ignore that directory for now.

Something else I noticed is that I dislike large pull requests like this one, they are hard to review and I always think that someone will try to PR a backdoor. Since this change is generated in an automated way, would it be possible for you to send me the command you're using to change the files and I just apply that command?

hougomartim
hougomartim commented Oct 30, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@hougomartim hougomartim left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for reviewing the more than 150 files.
i ignore the sqlmap directory and i search in history commands prompt, but i can`t find thats command.

@hougomartim
Copy link
Copy Markdown
Contributor Author

hougomartim commented Oct 30, 2019 •
edited
Loading

i will sending a small pull request in the next.
Thanks again./

@hougomartim
Copy link
Copy Markdown
Contributor Author

hougomartim commented Nov 3, 2019

can you merge this request?

@hougomartim
Copy link
Copy Markdown
Contributor Author

hougomartim commented Feb 9, 2020

this is ok?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andresriancho andresriancho Awaiting requested review from andresriancho

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hougomartim @andresriancho