Updated Dockerfile, added Jenkinsfile.#16523
Updated Dockerfile, added Jenkinsfile.#16523chadduffin wants to merge 2 commits intoandresriancho:masterfrom chadduffin:master
Conversation
…moved deprecated directives, and now successfully builds.
andresriancho
left a comment
There was a problem hiding this comment.
Thanks for this great PR, the dockerfile needed some maintenance 👍
Some of my comments went inline with the code, some other comments here:
-
Jenkinsfile: w3af uses circleci for builds (see circle.yml in root directory). When a build succeeds then a new docker image is build and pushed. Builds haven't been passing for some time now... that it why we don't get fresh docker images in hub.docker.com. Please remove this file since we won't use it: adding another build system doesn't make much sense. -
Please send the PR against the
developbranch which has significant improvements frommasterand, for example, a different set of pip requirements.
| @@ -0,0 +1,92 @@ | |||
| # w3af.org | |||
There was a problem hiding this comment.
I believe that we can safely remove this file, we don't really need the backup.
|
|
||
|
|
||
| CORE_PIP_PACKAGES = [PIPDependency('pyclamd', 'pyClamd', '0.3.15'), | ||
| CORE_PIP_PACKAGES = [PIPDependency('pyclamd', 'pyClamd', '0.4.0'), |
There was a problem hiding this comment.
Just upgraded develop to use this lib version
| PIPDependency('pdfminer', 'pdfminer', '20140328'), | ||
| PIPDependency('concurrent.futures', 'futures', '2.1.5'), | ||
| PIPDependency('OpenSSL', 'pyOpenSSL', '0.15.1'), | ||
| PIPDependency('OpenSSL', 'pyOpenSSL', '16.2.0'), |
There was a problem hiding this comment.
The develop branch already uses a newer version
An updated Dockerfile is important so that anyone can build and run W3AF anywhere. Along with being able to build it, it is useful to be able to build this image with CI so that the most up to date version can be easily and automatically maintained.
This pull request contains: