Skip to content

chore: update NumberParser's cldr data#9907

Open
snowystinger wants to merge 1 commit intomainfrom
update-cldr-data
Open

chore: update NumberParser's cldr data#9907
snowystinger wants to merge 1 commit intomainfrom
update-cldr-data

Conversation

@snowystinger
Copy link
Copy Markdown
Member

Closes

Just doing some maintenance. Note, 49 is currently not actually released, but they have the correct page and section and the script generates the same values for 48.2 and 49 (and 44), so i figured it was ok to set it to 49 ahead of time, it should be released pretty soon based on their usual cadence.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link
Copy Markdown

rspbot commented Apr 10, 2026

Copy link
Copy Markdown
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed that the 49 generated the same pluralNumbers set, but maybe we could try and automate this in some fashion so we don't need to remember to keep checking

@snowystinger
Copy link
Copy Markdown
Member Author

Yeah, we could poll https://github.com/unicode-org/cldr/releases or https://cldr.unicode.org/index/downloads nightly to find out when there is a new version, then when there is, run the script, see if it matches current values.
One problem though is that the script has sometimes needed tweaks to work with a new release because they changed the url or the data on the page.

Perhaps something like https://github.com/adobe/react-spectrum/compare/automate-cldr-upgrades?expand=1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants