Skip to content

Heroku-ready version of Staytus#240

Open
ideasasylum wants to merge 14 commits intoadamcooke:masterfrom
ideasasylum:master
Open

Heroku-ready version of Staytus#240
ideasasylum wants to merge 14 commits intoadamcooke:masterfrom
ideasasylum:master

Conversation

@ideasasylum
Copy link
Copy Markdown

First: This is something of an experiment rather than a PR that can be merged.

I wondered what it would take to make Staytus deployable to Heroku using a Heroku Button. It came down to:

  • Use Postgres: replace the mysql gem with pg; change the adapter in database.yml, remove the mysql-specific options from schema.rb
  • Add an app.json file specifying the default Heroku formation, config variables, etc.
  • Add the Heroku button to the README

You can try the Heroku button here in my fork's README

I've got no interest in maintaining a Heroku-specific fork, and I'm not even sure I have a use for Staytus right now, but I wondered if there was a way to have a single repo with both mysql and postgres dependancies? I'm not sure how this would work. Could an environment variable change which adapter is loaded? But how do we keep schema.rb database-agnostic?

Maybe some other interested and knowledgeable parties will find this and comment.

@ideasasylum ideasasylum mentioned this pull request Jul 15, 2018
@rdeavila
Copy link
Copy Markdown

rdeavila commented Jul 24, 2018

I'm running your fork on Heroku... and it's working well (except e-mails)! 😄

@hadifarnoud
Copy link
Copy Markdown

is this merged? if not, any reason?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants