chore(ui5-radio-button): make component customizable#13326
Open
TeodorTaushanov wants to merge 14 commits intomainfrom
Open
chore(ui5-radio-button): make component customizable#13326TeodorTaushanov wants to merge 14 commits intomainfrom
TeodorTaushanov wants to merge 14 commits intomainfrom
Conversation
Collaborator
|
🚀 Deployed on https://pr-13326--ui5-webcomponents-preview.netlify.app |
Contributor
LidiyaGeorgieva
left a comment
LidiyaGeorgieva
left a comment
There was a problem hiding this comment.
- When the label is wrapped and on several lines the vertical alignment of the first line is not like before (and as it is specified in the design)
(on Compact is OK)
-
Is it OK for the radio button to be 43.984px instead of 44px? var(--_ui5_radio_button_svg_size) equals 25.1424px (25.1424em)
-
the disabled button have more space between the circle and the label now
(on Compact is OK)
- on Cozy and Compact the buttons with the custom font-size are with different height? Shouldn't they be the same?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.