fix: typos in a user-facing success message, comments, and test descriptions#7300
Open
andromia3 wants to merge 1 commit intoShopify:mainfrom
Open
fix: typos in a user-facing success message, comments, and test descriptions#7300andromia3 wants to merge 1 commit intoShopify:mainfrom
andromia3 wants to merge 1 commit intoShopify:mainfrom
Conversation
…iptions All edits are 1:1 character fixes. Grouped by where the typo surfaces: User-facing CLI output (the only change that needs a changeset): - packages/app/src/cli/services/webhook/trigger.ts — the success message for `shopify app webhook trigger --delivery-method=localhost` said "Localhost delivery sucessful". Fixed to "successful", and updated the matching assertion in trigger.test.ts. Code comments: - packages/cli-kit/src/public/node/json-schema.ts — "where the union issue occured" -> "occurred". - packages/theme/src/cli/utilities/theme-uploader.ts — "Dependant and independant files are uploaded concurrently" -> "Dependent and independent". - packages/app/src/cli/services/app/config/link.ts — "Always use our prefered build options" -> "preferred". Test descriptions (strings passed to `test()`/`describe()`, safe to rename — no identifiers reference them): - packages/theme/src/cli/utilities/repl/evaluator.test.ts — "should add succesful assignments" -> "successful". - packages/app/src/cli/services/dev/extension/localization.test.ts — "returns the last succesful locale built" -> "successful". - packages/cli-kit/src/public/node/context/local.test.ts — "returns localhost when no cloud enviroment varible exist" had two typos on one line plus a subject-verb agreement slip; now "when no cloud environment variable exists". Patch changeset for @shopify/app covers the webhook trigger message — it's the only change a merchant-developer will actually see.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
A handful of typos across the codebase, including one in a user-facing CLI success message. All are 1:1 character fixes; no identifiers, no runtime behaviour, no types touched.
WHAT is this pull request doing?
User-facing CLI output (the one change that actually needs a changeset):
```diff
```
(`packages/app/src/cli/services/webhook/trigger.ts`) — printed when `shopify app webhook trigger --delivery-method=localhost` succeeds. The matching assertion in `trigger.test.ts` is updated in the same commit.
Code comments:
Test descriptions (strings passed to `test()`/`describe()`, safe to rename — no identifiers reference them):
How to test your changes?
The only runtime-visible change is the webhook success message. The existing test in `trigger.test.ts` is updated to assert on the corrected string, so the unit test still passes after the fix. Everything else is inside a comment or a test description — no functional impact.
```bash
pnpm --filter @shopify/app test trigger
```
Post-release steps
None.
Checklist