feat: add headers for destination consumption#56
Open
NicoleMGomes wants to merge 3 commits intomainfrom
Open
Conversation
ecfcf8e to
e290f70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extends
get_destinationto support all HTTP request headers defined by the SAP Destination Service v2 API. A new set of fields onConsumptionOptionsmaps directly to the correspondingX-*headers, enabling all OAuth2 token exchange flows, SAML assertion, authorization code, refresh token, destination chains, and optional fragment behaviour.New
ConsumptionOptionsfields:fragment_optionalX-fragment-optionaluser_tokenX-user-tokensubject_tokenX-subject-tokensubject_token_typeX-subject-token-typeactor_tokenX-actor-tokenactor_token_typeX-actor-token-typesaml_assertionX-samlAssertionrefresh_tokenX-refresh-tokencodeX-coderedirect_uriX-redirect-uricode_verifierX-code-verifierchain_nameX-chain-namechain_varsX-chain-var-<key>The existing
fragment_nameandtenantfields are unchanged.Related Issue
Closes #
Type of Change
How to Test
.venv/bin/pytest tests/destination/unit/test_client.py -q.venv/bin/pytest tests/destination/integration/ -qChecklist
Breaking Changes
None. All new
ConsumptionOptionsfields default toNoneand are omitted from the request when not set, preserving existing behaviour.Additional Notes
get_destinationhas grown in size (SonarQube flags cognitive complexity). A follow-up refactor can extract header building to a private method if the team prefers.