fix: correct SearchPageProps type and remove unnecessary await from params#576
fix: correct SearchPageProps type and remove unnecessary await from params#576ngoiyaeric wants to merge 2 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Review Summary by QodoFix SearchPageProps type and remove unnecessary await from params
WalkthroughsDescription• Corrects SearchPageProps type from Promise to synchronous object • Removes unnecessary await statements from params destructuring • Fixes type mismatch in generateMetadata and SearchPage functions Diagramflowchart LR
A["SearchPageProps<br/>params: Promise"] -->|"Remove Promise wrapper"| B["SearchPageProps<br/>params: object"]
C["await params<br/>in functions"] -->|"Remove await"| D["Direct params<br/>destructuring"]
B --> E["Type alignment<br/>with Next.js"]
D --> E
File Changes1. app/search/[id]/page.tsx
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewⓘ The new review experience is currently in Beta. Learn more |
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 51 minutes and 6 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughUpdated Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This PR fixes a type error in the SearchPageProps interface and removes unnecessary await from params in the search page, which was causing issues with multi-modal features in the Vercel deployment.
Summary by CodeRabbit