Fix: include inputs.caching-key in restore keys for proper cache restoration#76
Open
giovaborgogno wants to merge 1 commit intoNuitka:mainfrom
Open
Fix: include inputs.caching-key in restore keys for proper cache restoration#76giovaborgogno wants to merge 1 commit intoNuitka:mainfrom
giovaborgogno wants to merge 1 commit intoNuitka:mainfrom
Conversation
…keys. Updated to include the caching-key in both the primary and restore keys for improved cache management.
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdd the missing inputs.caching-key prefix to the cache restore-keys in action.yml so they align with the primary cache key and improve cache hit reliability. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Consider retaining a generic restore-key fallback without the caching-key prefix so you can still hit caches if the user changes the caching-key input.
- Validate or sanitize the inputs.caching-key value in the action schema to prevent invalid characters or empty segments in cache keys.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider retaining a generic restore-key fallback without the caching-key prefix so you can still hit caches if the user changes the caching-key input.
- Validate or sanitize the inputs.caching-key value in the action schema to prevent invalid characters or empty segments in cache keys.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in action.yml where inputs.caching-key was missing from the cache restore-keys.
Without it, cache restoration could fail to match the primary cache key, leading to unnecessary rebuilds.
The change adds inputs.caching-key to the restore-keys to ensure consistency with the main cache key and improve cache reuse across runs.
Summary by Sourcery
Fix cache restore-keys in action.yml to include inputs.caching-key for consistent cache matching and reuse
Bug Fixes:
CI: