Skip to content

Fix: include inputs.caching-key in restore keys for proper cache restoration#76

Open
giovaborgogno wants to merge 1 commit intoNuitka:mainfrom
giovaborgogno:main
Open

Fix: include inputs.caching-key in restore keys for proper cache restoration#76
giovaborgogno wants to merge 1 commit intoNuitka:mainfrom
giovaborgogno:main

Conversation

@giovaborgogno
Copy link
Copy Markdown

@giovaborgogno giovaborgogno commented Oct 30, 2025

This PR fixes an issue in action.yml where inputs.caching-key was missing from the cache restore-keys.
Without it, cache restoration could fail to match the primary cache key, leading to unnecessary rebuilds.

The change adds inputs.caching-key to the restore-keys to ensure consistency with the main cache key and improve cache reuse across runs.

Summary by Sourcery

Fix cache restore-keys in action.yml to include inputs.caching-key for consistent cache matching and reuse

Bug Fixes:

  • Include inputs.caching-key in restore-keys to ensure proper cache restoration

CI:

  • Add inputs.caching-key to secondary cache restore keys in action.yml

…keys. Updated to include the caching-key in both the primary and restore keys for improved cache management.
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Oct 30, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Add the missing inputs.caching-key prefix to the cache restore-keys in action.yml so they align with the primary cache key and improve cache hit reliability.

File-Level Changes

Change Details Files
Include inputs.caching-key in cache restore-keys
  • Add inputs.caching-key prefix to the restore-key line with Python version
  • Add inputs.caching-key prefix to the shorter restore-key line
action.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Consider retaining a generic restore-key fallback without the caching-key prefix so you can still hit caches if the user changes the caching-key input.
  • Validate or sanitize the inputs.caching-key value in the action schema to prevent invalid characters or empty segments in cache keys.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider retaining a generic restore-key fallback without the caching-key prefix so you can still hit caches if the user changes the caching-key input.
- Validate or sanitize the inputs.caching-key value in the action schema to prevent invalid characters or empty segments in cache keys.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jan 30, 2026

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants