Skip to content

Only build release on tag, else debug build#31

Open
jgeudens wants to merge 1 commit intomasterfrom
dev/release_on_tag
Open

Only build release on tag, else debug build#31
jgeudens wants to merge 1 commit intomasterfrom
dev/release_on_tag

Conversation

@jgeudens
Copy link
Copy Markdown
Member

@jgeudens jgeudens commented Apr 15, 2026

Summary by CodeRabbit

Release Notes

Chores

  • Build system now defaults to Debug builds across platforms.
  • Build type is determined dynamically: tagged releases produce Release builds; other refs produce Debug.
  • Build scripts accept a configurable build-type value for greater build flexibility and consistency.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 15, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8404c91b-ac67-47a0-99a0-b016c63cd57c

📥 Commits

Reviewing files that changed from the base of the PR and between 51004fb and 4c7b7c0.

📒 Files selected for processing (3)
  • .github/workflows/ccpp.yml
  • scripts/build_linux.sh
  • scripts/build_windows.bat
✅ Files skipped from review due to trivial changes (2)
  • scripts/build_linux.sh
  • .github/workflows/ccpp.yml
🚧 Files skipped from review as they are similar to previous changes (1)
  • scripts/build_windows.bat

Walkthrough

Workflow-level BUILD_TYPE added and set to Release for tag refs, Debug otherwise. Linux and Windows build scripts updated to read BUILD_TYPE (defaulting to Debug) and pass it into CMake as -DCMAKE_BUILD_TYPE.

Changes

Cohort / File(s) Summary
CI/CD Workflow Configuration
\.github/workflows/ccpp.yml
Added top-level env: BUILD_TYPE computed from github.ref (Release for tag refs, Debug otherwise).
Build Scripts
scripts/build_linux.sh, scripts/build_windows.bat
Changed CMake invocation to use BUILD_TYPE (-DCMAKE_BUILD_TYPE=${BUILD_TYPE} / %BUILD_TYPE%) and added fallback to Debug when unset.

Sequence Diagram(s)

sequenceDiagram
    participant GH as GitHub Actions Workflow
    participant Runner as Actions Runner
    participant Script as build_linux.sh / build_windows.bat
    participant CMake as CMake

    GH->>Runner: Start job with env BUILD_TYPE (computed from github.ref)
    Runner->>Script: Invoke build script
    Script->>Script: Read BUILD_TYPE (use Debug if unset)
    Script->>CMake: Run cmake -DCMAKE_BUILD_TYPE=BUILD_TYPE
    CMake-->>Script: Configure & generate build files
    Script-->>Runner: Continue build steps
Loading
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: a conditional build type selection based on whether the ref is a tag (Release) or not (Debug).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev/release_on_tag

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jgeudens jgeudens force-pushed the dev/release_on_tag branch from 51004fb to 4c7b7c0 Compare April 15, 2026 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant