London | 26-ITP-Jan | Karla Grajales | Sprint 3 | Quote generator#1198
Open
Grajales-K wants to merge 19 commits intoCodeYourFuture:mainfrom
Open
London | 26-ITP-Jan | Karla Grajales | Sprint 3 | Quote generator#1198Grajales-K wants to merge 19 commits intoCodeYourFuture:mainfrom
Grajales-K wants to merge 19 commits intoCodeYourFuture:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
Grajales-K
added
🏕 Priority Mandatory
cjyuan
reviewed
Apr 14, 2026
cjyuan
added
Reviewed
…layout" This reverts commit f0185ee.
…om quote functionality
Grajales-K
added
the
Needs Review
Contributor
|
Looks good. Nicely implemented. |
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Refactored the Quote Generator to improve code organization and user experience. The primary update involves a structural refactor, moving the quotes data into a separate file (data.js) to decouple data from application logic. Key features include an automated quote rotation mechanism (Stretch Goal) with a visual "auto-play:ON" status indicator and a manual "New Quote" trigger. I also integrated an audio element to enhance interactivity and updated the HTML metadata to match the project requirements. All core functionalities were tested to ensure the random selection logic works seamlessly with the provided array.