Skip to content

Sheffield | 26-ITP-Jan | Seti Mussa | Sprint 3 | Quote generator#1197

Open
Seti-Jemal wants to merge 2 commits intoCodeYourFuture:mainfrom
Seti-Jemal:Sprint--3-quote--generator
Open

Sheffield | 26-ITP-Jan | Seti Mussa | Sprint 3 | Quote generator#1197
Seti-Jemal wants to merge 2 commits intoCodeYourFuture:mainfrom
Seti-Jemal:Sprint--3-quote--generator

Conversation

@Seti-Jemal
Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I have completed the task.

@Seti-Jemal Seti-Jemal added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 13, 2026
Comment on lines +506 to +511
displayQuote();

// Change quote when button is clicked
document
.getElementById("new-quote")
.addEventListener("click", displayQuote); No newline at end of file
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Placing all the "run on load" code in one place is a good practice.
Would be even better to place the code
inside a function to make it clearer that "this is what runs when the page loads."

For examples,

function setup() {
  // code to be executed on page load
}

window.addEventListener('load', setup);

or

window.addEventListener('load', function() {
  // code to be executed on page load
});

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants