-
-
Notifications
You must be signed in to change notification settings - Fork 225
Birmingham | 26-ITP-Jan | Tasleem Adedokun | Sprint 2 | Book Library #428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tasleemadedokun
wants to merge
13
commits into
CodeYourFuture:main
Choose a base branch
from
tasleemadedokun:debugging-book-library
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+93
−95
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
545a578
Add a bracket in line 57 after n-- to enable the render function free…
tasleemadedokun d7e918d
Effect new change on line 47 to replace library.push with myLibrary.push
tasleemadedokun a0563ad
Change the html onclick submit to addbook and implement the function …
tasleemadedokun fcc41d9
Replace one of the title.value to author.value.
tasleemadedokun f71d019
Replace all delbut with delButton
tasleemadedokun aee0f7c
Replace line 79 with true.
tasleemadedokun afb91d1
validate the author also.
tasleemadedokun b502367
Implement new change.
tasleemadedokun c4f0426
update changes.
tasleemadedokun 50224a3
Remove the other render inside the function populateStorage.
tasleemadedokun 86339e5
Remove the strings in numbers 252 and 127.
tasleemadedokun 2cad409
Update html, buy adding title name Library, improve meta tag, ensure…
tasleemadedokun b8f4d08
Update new script.js
tasleemadedokun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,46 +1,48 @@ | ||
| let myLibrary = []; | ||
| const myLibrary = []; | ||
|
|
||
| window.addEventListener("load", function (e) { | ||
| window.addEventListener("load", () => { | ||
| populateStorage(); | ||
| render(); | ||
| }); | ||
|
|
||
| function populateStorage() { | ||
| if (myLibrary.length == 0) { | ||
| let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true); | ||
| let book2 = new Book( | ||
| if (myLibrary.length === 0) { | ||
| const book1 = new Book("Robinson Crusoe", "Daniel Defoe", 252, true); | ||
| const book2 = new Book( | ||
| "The Old Man and the Sea", | ||
| "Ernest Hemingway", | ||
| "127", | ||
| 127, | ||
| true | ||
| ); | ||
| myLibrary.push(book1); | ||
| myLibrary.push(book2); | ||
| render(); | ||
|
|
||
| myLibrary.push(book1, book2); | ||
| } | ||
| } | ||
|
|
||
| const title = document.getElementById("title"); | ||
| const author = document.getElementById("author"); | ||
| const pages = document.getElementById("pages"); | ||
| const check = document.getElementById("check"); | ||
|
|
||
| //check the right input from forms and if its ok -> add the new book (object in array) | ||
| //via Book function and start render function | ||
| function submit() { | ||
| if ( | ||
| title.value == null || | ||
| title.value == "" || | ||
| pages.value == null || | ||
| pages.value == "" | ||
| ) { | ||
| alert("Please fill all fields!"); | ||
| return false; | ||
| } else { | ||
| let book = new Book(title.value, title.value, pages.value, check.checked); | ||
| library.push(book); | ||
| render(); | ||
| const titleInput = document.getElementById("title"); | ||
| const authorInput = document.getElementById("author"); | ||
| const pagesInput = document.getElementById("pages"); | ||
| const checkInput = document.getElementById("check"); | ||
|
|
||
| function addBook() { | ||
| const titleValue = titleInput.value.trim(); | ||
| const authorValue = authorInput.value.trim(); | ||
| const pagesValue = Number(pagesInput.value); | ||
|
|
||
| if (!titleValue || !authorValue || pagesValue <= 0) { | ||
| alert("Please fill all fields correctly!"); | ||
| return; | ||
| } | ||
|
|
||
| const book = new Book( | ||
| titleValue, | ||
| authorValue, | ||
| pagesValue, | ||
| checkInput.checked | ||
| ); | ||
| myLibrary.push(book); | ||
|
|
||
| render(); | ||
| } | ||
|
|
||
| function Book(title, author, pages, check) { | ||
|
|
@@ -51,53 +53,53 @@ function Book(title, author, pages, check) { | |
| } | ||
|
|
||
| function render() { | ||
| let table = document.getElementById("display"); | ||
| let rowsNumber = table.rows.length; | ||
| //delete old table | ||
| for (let n = rowsNumber - 1; n > 0; n-- { | ||
| table.deleteRow(n); | ||
| } | ||
| //insert updated row and cells | ||
| let length = myLibrary.length; | ||
| for (let i = 0; i < length; i++) { | ||
| let row = table.insertRow(1); | ||
| let titleCell = row.insertCell(0); | ||
| let authorCell = row.insertCell(1); | ||
| let pagesCell = row.insertCell(2); | ||
| let wasReadCell = row.insertCell(3); | ||
| let deleteCell = row.insertCell(4); | ||
| titleCell.innerHTML = myLibrary[i].title; | ||
| authorCell.innerHTML = myLibrary[i].author; | ||
| pagesCell.innerHTML = myLibrary[i].pages; | ||
|
|
||
| //add and wait for action for read/unread button | ||
| let changeBut = document.createElement("button"); | ||
| changeBut.id = i; | ||
| changeBut.className = "btn btn-success"; | ||
| wasReadCell.appendChild(changeBut); | ||
| let readStatus = ""; | ||
| if (myLibrary[i].check == false) { | ||
| readStatus = "Yes"; | ||
| } else { | ||
| readStatus = "No"; | ||
| } | ||
| changeBut.innerText = readStatus; | ||
|
|
||
| changeBut.addEventListener("click", function () { | ||
| myLibrary[i].check = !myLibrary[i].check; | ||
| const table = document.getElementById("display"); | ||
|
|
||
| table.innerHTML = ` | ||
| <tr> | ||
| <th>Title</th> | ||
| <th>Author</th> | ||
| <th>Pages</th> | ||
| <th>Read</th> | ||
| <th>Delete</th> | ||
| </tr> | ||
| `; | ||
|
Comment on lines
+56
to
+66
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You could also just clear |
||
|
|
||
| myLibrary.forEach((book, i) => { | ||
| const row = table.insertRow(); | ||
|
|
||
| const titleCell = row.insertCell(0); | ||
| const authorCell = row.insertCell(1); | ||
| const pagesCell = row.insertCell(2); | ||
| const wasReadCell = row.insertCell(3); | ||
| const deleteCell = row.insertCell(4); | ||
|
|
||
| titleCell.textContent = book.title; | ||
| authorCell.textContent = book.author; | ||
| pagesCell.textContent = book.pages; | ||
|
|
||
| const changeBtn = document.createElement("button"); | ||
| changeBtn.className = "btn btn-success"; | ||
| changeBtn.textContent = book.check ? "Yes" : "No"; | ||
|
|
||
| changeBtn.addEventListener("click", () => { | ||
| book.check = !book.check; | ||
| render(); | ||
| }); | ||
|
|
||
| //add delete button to every row and render again | ||
| let delButton = document.createElement("button"); | ||
| delBut.id = i + 5; | ||
| deleteCell.appendChild(delBut); | ||
| delBut.className = "btn btn-warning"; | ||
| delBut.innerHTML = "Delete"; | ||
| delBut.addEventListener("clicks", function () { | ||
| alert(`You've deleted title: ${myLibrary[i].title}`); | ||
| wasReadCell.appendChild(changeBtn); | ||
|
|
||
| const deleteBtn = document.createElement("button"); | ||
| deleteBtn.className = "btn btn-warning"; | ||
| deleteBtn.textContent = "Delete"; | ||
|
|
||
| deleteBtn.addEventListener("click", () => { | ||
| myLibrary.splice(i, 1); | ||
| render(); | ||
| alert(`You've deleted title: ${book.title}`); | ||
| }); | ||
| } | ||
|
|
||
| deleteCell.appendChild(deleteBtn); | ||
| }); | ||
| } | ||
| window.addBook = addBook; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pagesValuecould beNaN.