[Common] Adding configurable to reduce memory usage for muon track extension#15784
Open
lucamicheletti93 wants to merge 3 commits intoAliceO2Group:masterfrom
Open
[Common] Adding configurable to reduce memory usage for muon track extension#15784lucamicheletti93 wants to merge 3 commits intoAliceO2Group:masterfrom
lucamicheletti93 wants to merge 3 commits intoAliceO2Group:masterfrom
Conversation
|
O2 linter results: ❌ 2 errors, |
lucamicheletti93
requested review from
a team,
alibuild,
ddobrigk,
dsekihat,
iarsene,
jgrosseo and
ktf
as code owners
Collaborator
|
@lucamicheletti93 This is not a PWGDQ PR. |
vkucera
changed the title
github-actions
bot
changed the title
vkucera
reviewed
Apr 15, 2026
| dcaX = (proptrack.getX() - collision.posX()); | ||
| dcaY = (proptrack.getY() - collision.posY()); | ||
| } else { | ||
| dcaX = track.pDca() / sqrt(2) / track.p(); |
Collaborator
There was a problem hiding this comment.
Consider using std::numbers::sqrt2 from <numbers>.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configurable to exclude the loading of the full geometru for the DCA calculation. With no propagation as in the old version of the task allows to reduce the memory consumption of a factor ~20 (from ~450MB to ~20MB). The test produced is saved in this repository: https://cernbox.cern.ch/files/spaces/eos/user/l/lmichele/FwdTrackExtension_test
THe performance metrics can be loaded here to see the impact of the option.