[PWGJE] Rename Ds jet task and add THnSparse histograms#15749
Open
monamelop wants to merge 4 commits intoAliceO2Group:masterfrom
Open
[PWGJE] Rename Ds jet task and add THnSparse histograms#15749monamelop wants to merge 4 commits intoAliceO2Group:masterfrom
monamelop wants to merge 4 commits intoAliceO2Group:masterfrom
Conversation
|
O2 linter results: ❌ 1 errors, |
Collaborator
|
@vkucera can you check if the includes modification here is reasonable to you please? |
Collaborator
No, it doesn't look reasonable. |
vkucera
reviewed
Apr 14, 2026
vkucera
reviewed
Apr 14, 2026
93e1096 to
e3e2701
Compare
Contributor
Author
|
I rebased the branch on the latest master and cleaned up the changes.
The code runs correctly locally now. |
Contributor
Author
|
Hi, The CI failure is due to O2 linter errors in PWGJE/Tasks/CMakeLists.txt related to workflow naming inconsistencies (e.g. emcCellMonitor, photonIsolationQA, etc.). These are pre-existing issues and not introduced by this PR. My changes only affect the renaming of my task (jetDsSpecSubs), and I did not modify the other workflows. Please let me know how to proceed. Best, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This PR renames the Ds jet analysis task and introduces THnSparse-based observables.
Changes:
The task jetDsSpectrumAndSubstructure was introduced during development and is not used elsewhere. This PR consolidates the final version under the name jetDsSpecSubs.
This PR has been cleaned and rebased on the latest master to include only the relevant changes.
Please let me know if you would prefer splitting the rename and the new features into separate PRs.
Thanks!