Skip to content

[PWGJE] Rename Ds jet task and add THnSparse histograms#15749

Open
monamelop wants to merge 4 commits intoAliceO2Group:masterfrom
monamelop:ds-spec-subs-clean
Open

[PWGJE] Rename Ds jet task and add THnSparse histograms#15749
monamelop wants to merge 4 commits intoAliceO2Group:masterfrom
monamelop:ds-spec-subs-clean

Conversation

@monamelop
Copy link
Copy Markdown
Contributor

Hi,

This PR renames the Ds jet analysis task and introduces THnSparse-based observables.

Changes:

  • Rename task: jetDsSpectrumAndSubstructure -> jetDsSpecSubs
  • Update workflow name accordingly
  • Add THnSparse histograms
  • Add corresponding workflow entry in CMakeLists

The task jetDsSpectrumAndSubstructure was introduced during development and is not used elsewhere. This PR consolidates the final version under the name jetDsSpecSubs.

This PR has been cleaned and rebased on the latest master to include only the relevant changes.

Please let me know if you would prefer splitting the rename and the new features into separate PRs.

Thanks!

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 13, 2026

O2 linter results: ❌ 1 errors, ⚠️ 2 warnings, 🔕 0 disabled

@nzardosh
Copy link
Copy Markdown
Collaborator

@vkucera can you check if the includes modification here is reasonable to you please?

@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented Apr 14, 2026

@vkucera can you check if the includes modification here is reasonable to you please?

No, it doesn't look reasonable.

Comment thread PWGJE/Tasks/jetDsSpecSubs.cxx Outdated
Comment thread PWGJE/Tasks/jetDsSpecSubs.cxx Outdated
@monamelop monamelop force-pushed the ds-spec-subs-clean branch from 93e1096 to e3e2701 Compare April 15, 2026 16:59
@monamelop
Copy link
Copy Markdown
Contributor Author

I rebased the branch on the latest master and cleaned up the changes.

  • The task was renamed from jetDsSpectrumAndSubstructure to jetDsSpecSubs.
  • I also removed the unused AOD table and simplified it to a histogram-only task.
  • The CMakeLists.txt was updated accordingly to reflect the new task name (jet-ds-spec-subs).

The code runs correctly locally now.

@monamelop
Copy link
Copy Markdown
Contributor Author

Hi,

The CI failure is due to O2 linter errors in PWGJE/Tasks/CMakeLists.txt related to workflow naming inconsistencies (e.g. emcCellMonitor, photonIsolationQA, etc.).

These are pre-existing issues and not introduced by this PR. My changes only affect the renaming of my task (jetDsSpecSubs), and I did not modify the other workflows.

Please let me know how to proceed.

Best,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants