[Common,DPG,PWGDQ,PWGEM,PWGLF,PWGUD] bulk rename for include DPLAlpideParam#15676
Open
f3sch wants to merge 2 commits intoAliceO2Group:masterfrom
Open
[Common,DPG,PWGDQ,PWGEM,PWGLF,PWGUD] bulk rename for include DPLAlpideParam#15676f3sch wants to merge 2 commits intoAliceO2Group:masterfrom
f3sch wants to merge 2 commits intoAliceO2Group:masterfrom
Conversation
github-actions
bot
changed the title
|
O2 linter results: ❌ 418 errors, |
In O2#15188 we changed the location of the DPLAlpideParam class to avoid pulling in the whole ITSMFTBase library into many wfx. In PR, I left a redirect, currently, which can be removed after the rename. I did not compile it but it should work since any file currently linking against ITSMFTBase is also linked against DataFormatsITSMFT. Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
f3sch
requested review from
alibuild,
amatyja,
dsekihat,
ercolessi,
feisenhu,
hscheid,
iarsene,
jokonig,
lhusova,
lucamicheletti93,
mcoquet642,
mikesas,
mpuccio,
omvazque,
rbailhac,
rolavick,
romainschotter and
skundu692
as code owners
f3sch
requested review from
a team,
altsybee,
ddobrigk,
ekryshen,
jgrosseo,
ktf and
strogolo
as code owners
amatyja
previously approved these changes
Apr 14, 2026
Collaborator
amatyja
left a comment
amatyja
left a comment
There was a problem hiding this comment.
UD part is fine, thanks.
rolavick
previously approved these changes
Apr 15, 2026
romainschotter
previously approved these changes
Apr 15, 2026
f3sch
dismissed stale reviews from romainschotter, rolavick, and amatyja
via
d684baf
Contributor
Author
|
sorry @rolavick, @amatyja, @romainschotter to as again for approval, there was a merge conflict in the meanwhile which I fixed up now. |
amatyja
approved these changes
Apr 15, 2026
romainschotter
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In O2#15188 we changed the location of the DPLAlpideParam class to avoid pulling in the whole ITSMFTBase library into many wfx. In PR, I left a redirect, currently, which can be removed after the rename.
I did not compile it but it should work since any file currently linking against ITSMFTBase is also linked against DataFormatsITSMFT.
Once the PR is merged, I will undraft here.