Skip to content

PCbuild/build.bat does not propagate the PGO test run exit code #148644

@rdesgroppes

Description

@rdesgroppes

Bug report

Bug description:

If python.bat %pgo_job% fails, the build silently succeeds because %ERRORLEVEL% is reset by subsequent commands inside the same parenthesized block (eager evaluation).

A proposed fix would be to split the block after @echo off, save %ERRORLEVEL% outside the block, and check it after call :Kill.

CPython versions tested on:

3.13, CPython main branch

Operating systems tested on:

Windows

Linked PRs

Metadata

Metadata

Assignees

No one assigned

    Labels

    OS-windowsbuildThe build process and cross-buildtype-bugAn unexpected behavior, bug, or error

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions