move search in page to page options button

[Popolechien]

Search entry and search in page are currently at the same place, which is confusing for usersm see e.g. https://www.reddit.com/r/Kiwix/comments/1rh9u58/is_it_possible_to_search_a_specific_article_on/ and comments

Search in page should be moved to the page options itself so as to avoid confusion and align with other apps.

[kelson42]

@Popolechien We already have an issue about that and I will close this issue once properly linked. We will implement a fix to the current situation in 4.0.0. At this stage, I only need to make a decision about the best approach.

[atharvyadav22]

@Popolechien @kelson42 i am migrating the Search Fragment alongside i have fixed many releated issues #4703 (comment)
PR is done mostly if you want i can also move that "Find in Page from Search bar to option menu" ?

[kelson42]

@atharvyadav22 will come back tomorrow to you on this matter

[MohitMaliFtechiz]

@Popolechien, @kelson42, This is the old issue we have #1782. Now, it been a long time since the old issue was opened. We have previously analyzed this situation #1782 (comment), and at that time, we did not make any decision on it. But now, I also think it is a little bit confusing for users that FIND_IN_PAGE is inside the searchScreen, which is confusing for users.

• The first thing, the option is for searching in the currently opened page, so it should be on the same screen(So that users can easily know about the features for the current screen, as we have "Read aloud", "Random article", etc).
• It is unnecessary to open the search screen just to use the "FIND IN PAGE" feature. Because users have to perform some extra steps to use the functionality. However, they can simply use it on the same page.
• In the current approach, when we open the search screen, there are some extra memory/libkiwix(Opening screen and it loads recently searched from DB, and users have to type something which calls the libkiwix search API) operations performed that are unnecessary.