Skip to content

[Bug] Search for changed files is limited to the first 30 files in the PR #431

@alexdupre

Description

@alexdupre

Describe the bug

We noticed that the action wasn't optimizing all images added in the PR. The reason is likely attributable to the missing pagination here: https://github.com/calibreapp/image-actions/blob/main/src/get-changed-images.ts#L23-L29

Octokit documentation: https://octokit.github.io/rest.js/v22/#pagination

How To Reproduce

Create a Pull Request with more than 30 added images

Screenshots

No response

Relevant Log Output

Found 30 images to process: ...

Code of Conduct

  • I agree to follow this project’s Code of Conduct

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggood first issueGood for newcomershelp wantedExtra attention is needed

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions