PCECD support/correct parameters

[eadmaster]

I'm trying to use edcre to fix this patch:
In Magical Adventure - Fray CD - Xak Gaiden (Japan) (Track 02).bin.xdelta.zip

$ edcre -t v "In Magical Adventure - Fray CD - Xak Gaiden (Japan) (Track 02) (patched).bin"

EDCRE v1.1.0 - EDC/ECC Regenerator
(c) 2023-2025 Alex Free (GNU GPLv2)
https://alex-free.github.io/edcre

Made Possible By Modifying CDRDAO (GPLv2) Source Code:
https://github.com/cdrdao/cdrdao

Progress: 100%
CDDA sectors detected, data sector read complete.
All scanned sectors already contain valid ECC/EDC data

I'm quite sure this has bad EDC data, since disabling this check is required to make it playable in mednafen.

[alex-free]

Typically track 1 is data and track 2 is CDDA. Only data sectors will have EDC/ECC.

[eadmaster]

This is the target image.

[alex-free]

Interesting it says track 2 and track 56 are data tracks.

[eadmaster]

error scan with CDmage:

Beetle PCE freezes with Uncorrectable data at sector 4142.

[alex-free]

The thing with emulators is they almost always ignore EDC/ECC and regenerate on the fly, I actually don’t know any PS1 emulator that doesn’t. Now Madnefan might be different but I suspect this may be something else.

CDMage is a great comparison to do here. I can’t remember what Yes/No is saying with CDMage. Is it saying there are issues with EDC/ECC?

Does the md5sum of the tracks match redump?

Does repairing it with CDMage fix your issue?

[alex-free]

I wonder if doing edcre -k would fix this on a clean rip? Make sure you use a redump style image (all tracks separate bin files) and then edcre -k track 2 ecre-k track 56

[NightWolve75]

Interesting it says track 2 and track 56 are data tracks.

Yeah, PC Engine/TurboGrafx-CD mixed-mode game CDs always start with a CDDA wave track to issue a warning, telling you that it's a game disc for use with the HE/TurboGrafx CD ROM system and to remove it from your CD player before it hurts your speakers, that sort of thing, since when it hits the next track, it'll try to play it but obviously output obnoxious static/noise.

That was the Hudson/NEC standard when they hit the market with game CDs. The data tracks also don't use the ISO file system, they're compiled game ROM binaries like carts/hucards, etc. Sega/Mega CDs began the standard with data track 1, no warning audio, that you're used to/thinking of.

[alex-free]

Interesting it says track 2 and track 56 are data tracks.

Yeah, PC Engine/TurboGrafx-CD mixed-mode game CDs always start with a CDDA wave track to issue a warning, telling you that it's a game disc for use with the HE/TurboGrafx CD ROM system and to remove it from your CD player before it hurts your speakers, that sort of thing, since when it hits the next track, it'll try to play it but obviously output obnoxious static/noise.

That was the Hudson/NEC standard when they hit the market with game CDs. The data tracks also don't use the ISO file system, they're compiled game ROM binaries like carts/hucards, etc. Sega/Mega CDs began the standard with data track 1, no warning audio, that you're used to/thinking of.

Let me know if edcre -k on both data tracks works

[NightWolve75]

Let me know if edcre -k on both data tracks works

OH, it's from you! Interesting, a few days ago elmer actually showed me your edcre tool because I'm upgrading my TurboRip tool/app to support CD image file set conversion (convert BIN/CUE files to ISO/WAV/CUE or Redump/BIN/BIN/CUE and back again) and I was wondering if I should add support for EDC checking/testing/regenerating for MODE2 PS1 images. Once I read your docs that pretty much EDC/ECC is always regenerated by burning software and ignored by emulators, I guess I understood why it was never much of a problem for modders/localizers to patch raw MODE2/2352 data tracks and not run into problems later.

[alex-free]

Let me know if edcre -k on both data tracks works

OH, it's from you! Interesting, a few days ago elmer actually showed me your edcre tool because I'm upgrading my TurboRip tool/app to support CD image file set conversion (convert BIN/CUE files to ISO/WAV/CUE or Redump/BIN/BIN/CUE and back again) and I was wondering if I should add support for EDC checking/testing/regenerating for MODE2 PS1 images. Once I read your docs that pretty much EDC/ECC is always regenerated by burning software and ignored by emulators, I guess I understood why it was never much of a problem for modders/localizers to patch raw MODE2/2352 data tracks and not run into problems later.

Yea unless you are burning in raw mode (don't think you need to here) or want it 'proper' it doesn't matter because almost every burning software will regenerate it on the fly before burning

[eadmaster]

Let me know if edcre -k on both data tracks works

no error found:

$ edcre -t -v -k "In Magical Adventure - Fray CD - Xak Gaiden (Japan) (Track 02) (patched).bin"

EDCRE v1.1.0 - EDC/ECC Regenerator
(c) 2023-2025 Alex Free (GNU GPLv2)
https://alex-free.github.io/edcre

Made Possible By Modifying CDRDAO (GPLv2) Source Code:
https://github.com/cdrdao/cdrdao

Using existing sector header from data file
Progress: 100%Sector: 1/3245)
CDDA sectors detected, data sector read complete.

*************
*Scan Report*
*************

0 Mode 1 Sector(s)
0 Mode 2 Form 1 Sector(s)
0 Mode 2 Form 2 Sector(s)

All scanned sectors already contain valid ECC/EDC data

EDIT: as a workaround, converting to iso with bchunk also bypass the issue.