diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index c6093f271..da1104fa0 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -10,22 +10,20 @@ env: jobs: build: runs-on: ubuntu-latest - if: "! contains(github.event.head_commit.message, '[skip ci]')" - - strategy: - matrix: - node-version: [24.x] steps: - uses: actions/checkout@v6 - - name: Use Node.js ${{ matrix.node-version }} + - name: Install Node.js uses: actions/setup-node@v6 with: - node-version: ${{ matrix.node-version }} + node-version: 24.x - name: Install dependencies run: npm install + - name: Execute tests + run: npm run test + - name: Build and validate all steps - run: node tools/builder + run: npm run build diff --git a/package.json b/package.json index fb8cd6ce3..95837e0a1 100644 --- a/package.json +++ b/package.json @@ -23,8 +23,10 @@ }, "scripts": { "build": "node tools/builder", + "download-assets": "node tools/utils/download-assets", "start": "node tools/dev-server", - "download-assets": "node tools/utils/download-assets" + "test": "npm run typecheck", + "typecheck": "npm run typecheck --workspaces --if-present" }, "devDependencies": { "@highlightjs/cdn-assets": "^11.11.1", diff --git a/packages/quickstart/steps/01/package.json b/packages/quickstart/steps/01/package.json index caed058a6..c6019c80e 100644 --- a/packages/quickstart/steps/01/package.json +++ b/packages/quickstart/steps/01/package.json @@ -5,7 +5,8 @@ "author": "SAP SE", "description": "UI5 Demo App - Quickstart Tutorial", "scripts": { - "start": "ui5 serve -o index.html" + "start": "ui5 serve -o index.html", + "typecheck": "tsc --noEmit" }, "devDependencies": { "@types/openui5": "^1.146.0", diff --git a/packages/quickstart/steps/02/package.json b/packages/quickstart/steps/02/package.json index 6cb581674..f7e8e12a9 100644 --- a/packages/quickstart/steps/02/package.json +++ b/packages/quickstart/steps/02/package.json @@ -5,7 +5,8 @@ "author": "SAP SE", "description": "UI5 Demo App - Quickstart Tutorial", "scripts": { - "start": "ui5 serve -o index.html" + "start": "ui5 serve -o index.html", + "typecheck": "tsc --noEmit" }, "devDependencies": { "@types/openui5": "^1.146.0", diff --git a/packages/quickstart/steps/03/package.json b/packages/quickstart/steps/03/package.json index bd0d5105b..3bb72c1e6 100644 --- a/packages/quickstart/steps/03/package.json +++ b/packages/quickstart/steps/03/package.json @@ -5,7 +5,8 @@ "author": "SAP SE", "description": "UI5 Demo App - Quickstart Tutorial", "scripts": { - "start": "ui5 serve -o index.html" + "start": "ui5 serve -o index.html", + "typecheck": "tsc --noEmit" }, "devDependencies": { "@types/openui5": "^1.146.0", diff --git a/packages/walkthrough/steps/02/package.json b/packages/walkthrough/steps/02/package.json index 31217368f..9794d3c36 100644 --- a/packages/walkthrough/steps/02/package.json +++ b/packages/walkthrough/steps/02/package.json @@ -5,7 +5,8 @@ "description": "OpenUI5 TypeScript Walkthrough: Step 2 - Bootstrap", "private": true, "scripts": { - "start": "ui5 serve -o index.html" + "start": "ui5 serve -o index.html", + "typecheck": "tsc --noEmit" }, "devDependencies": { "@ui5/cli": "^4.0.51", diff --git a/packages/walkthrough/steps/03/package.json b/packages/walkthrough/steps/03/package.json index f8252b1b5..e261e78b0 100644 --- a/packages/walkthrough/steps/03/package.json +++ b/packages/walkthrough/steps/03/package.json @@ -5,7 +5,8 @@ "description": "OpenUI5 TypeScript Walkthrough: Step 3 - Controls", "private": true, "scripts": { - "start": "ui5 serve -o index.html" + "start": "ui5 serve -o index.html", + "typecheck": "tsc --noEmit" }, "devDependencies": { "@types/openui5": "^1.146.0", diff --git a/packages/walkthrough/steps/04/package.json b/packages/walkthrough/steps/04/package.json index 654903402..2f688429f 100644 --- a/packages/walkthrough/steps/04/package.json +++ b/packages/walkthrough/steps/04/package.json @@ -5,7 +5,8 @@ "description": "OpenUI5 TypeScript Walkthrough: Step 4: XML Views", "private": true, "scripts": { - "start": "ui5 serve -o index.html" + "start": "ui5 serve -o index.html", + "typecheck": "tsc --noEmit" }, "devDependencies": { "@types/openui5": "^1.146.0", diff --git a/packages/walkthrough/steps/05/package.json b/packages/walkthrough/steps/05/package.json index 1274efd4d..688038f1a 100644 --- a/packages/walkthrough/steps/05/package.json +++ b/packages/walkthrough/steps/05/package.json @@ -5,7 +5,8 @@ "description": "OpenUI5 TypeScript Walkthrough: Step 5: Controllers", "private": true, "scripts": { - "start": "ui5 serve -o index.html" + "start": "ui5 serve -o index.html", + "typecheck": "tsc --noEmit" }, "devDependencies": { "@types/openui5": "^1.146.0", diff --git a/packages/walkthrough/steps/06/package.json b/packages/walkthrough/steps/06/package.json index 4fd914eb7..c51c7471f 100644 --- a/packages/walkthrough/steps/06/package.json +++ b/packages/walkthrough/steps/06/package.json @@ -5,7 +5,8 @@ "description": "OpenUI5 TypeScript Walkthrough: Step 6: Modules", "private": true, "scripts": { - "start": "ui5 serve -o index.html" + "start": "ui5 serve -o index.html", + "typecheck": "tsc --noEmit" }, "devDependencies": { "@types/openui5": "^1.146.0", diff --git a/packages/walkthrough/steps/07/package.json b/packages/walkthrough/steps/07/package.json index 9ac288c64..756f9d77c 100644 --- a/packages/walkthrough/steps/07/package.json +++ b/packages/walkthrough/steps/07/package.json @@ -5,7 +5,8 @@ "description": "OpenUI5 TypeScript Walkthrough: Step 7: JSON Model", "private": true, "scripts": { - "start": "ui5 serve -o index.html" + "start": "ui5 serve -o index.html", + "typecheck": "tsc --noEmit" }, "devDependencies": { "@types/openui5": "^1.146.0", diff --git a/packages/walkthrough/steps/08/README.md b/packages/walkthrough/steps/08/README.md index 07c630c51..78e9c42b7 100644 --- a/packages/walkthrough/steps/08/README.md +++ b/packages/walkthrough/steps/08/README.md @@ -88,7 +88,7 @@ export default class AppController extends Controller { // read msg from i18n model const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name"); const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle; - const msg = resourceBundle.getText("helloMsg", [recipient]); + const msg = resourceBundle.getText("helloMsg", [recipient]) as string; // show message MessageToast.show(msg); } @@ -121,7 +121,7 @@ sap.ui.define(["sap/m/MessageToast", "sap/ui/core/mvc/Controller", "sap/ui/model // read msg from i18n model const recipient = this.getView()?.getModel()?.getProperty("/recipient/name"); const resourceBundle = this.getView()?.getModel("i18n")?.getResourceBundle(); - const msg = resourceBundle.getText("helloMsg", [recipient]); + const msg = resourceBundle.getText("helloMsg", [recipient]) as string; // show message MessageToast.show(msg); } diff --git a/packages/walkthrough/steps/08/package.json b/packages/walkthrough/steps/08/package.json index c897831c1..8d0292562 100644 --- a/packages/walkthrough/steps/08/package.json +++ b/packages/walkthrough/steps/08/package.json @@ -5,7 +5,8 @@ "description": "OpenUI5 TypeScript Walkthrough: Step 8: Translatable Texts", "private": true, "scripts": { - "start": "ui5 serve -o index.html" + "start": "ui5 serve -o index.html", + "typecheck": "tsc --noEmit" }, "devDependencies": { "@types/openui5": "^1.146.0", diff --git a/packages/walkthrough/steps/08/webapp/controller/App.controller.ts b/packages/walkthrough/steps/08/webapp/controller/App.controller.ts index 0dbbe2093..524aa5bfe 100644 --- a/packages/walkthrough/steps/08/webapp/controller/App.controller.ts +++ b/packages/walkthrough/steps/08/webapp/controller/App.controller.ts @@ -30,7 +30,7 @@ export default class AppController extends Controller { // read msg from i18n model const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name"); const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle; - const msg = resourceBundle.getText("helloMsg", [recipient]); + const msg = resourceBundle.getText("helloMsg", [recipient]) as string; // show message MessageToast.show(msg); } diff --git a/packages/walkthrough/steps/09/README.md b/packages/walkthrough/steps/09/README.md index a2f7ffaf3..5196f7f32 100644 --- a/packages/walkthrough/steps/09/README.md +++ b/packages/walkthrough/steps/09/README.md @@ -158,7 +158,7 @@ export default class AppController extends Controller { // read msg from i18n model const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name"); const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle; - const msg = resourceBundle.getText("helloMsg", [recipient]); + const msg = resourceBundle.getText("helloMsg", [recipient]) as string; // show message MessageToast.show(msg); } @@ -179,7 +179,7 @@ sap.ui.define(["sap/m/MessageToast", "sap/ui/core/mvc/Controller"], function (Me // functions with generic return values require casting const resourceBundle = this.getView()?.getModel("i18n")?.getResourceBundle(); const recipient = this.getView()?.getModel()?.getProperty("/recipient/name"); - const msg = resourceBundle.getText("helloMsg", [recipient]); + const msg = resourceBundle.getText("helloMsg", [recipient]) as string; // show message MessageToast.show(msg); } diff --git a/packages/walkthrough/steps/09/package.json b/packages/walkthrough/steps/09/package.json index 370974ac1..6a95aeadc 100644 --- a/packages/walkthrough/steps/09/package.json +++ b/packages/walkthrough/steps/09/package.json @@ -5,7 +5,8 @@ "description": "OpenUI5 TypeScript Walkthrough: Step 9 - Component Configuration", "private": true, "scripts": { - "start": "ui5 serve -o index.html" + "start": "ui5 serve -o index.html", + "typecheck": "tsc --noEmit" }, "devDependencies": { "@types/openui5": "^1.146.0", diff --git a/packages/walkthrough/steps/09/webapp/controller/App.controller.ts b/packages/walkthrough/steps/09/webapp/controller/App.controller.ts index d7877c8e4..29058d442 100644 --- a/packages/walkthrough/steps/09/webapp/controller/App.controller.ts +++ b/packages/walkthrough/steps/09/webapp/controller/App.controller.ts @@ -13,7 +13,7 @@ export default class AppController extends Controller { // functions with generic return values require casting const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle; const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name"); - const msg = resourceBundle.getText("helloMsg", [recipient]); + const msg = resourceBundle.getText("helloMsg", [recipient]) as string; // show message MessageToast.show(msg); } diff --git a/packages/walkthrough/steps/10/package.json b/packages/walkthrough/steps/10/package.json index 976c9501f..53b985fd2 100644 --- a/packages/walkthrough/steps/10/package.json +++ b/packages/walkthrough/steps/10/package.json @@ -5,7 +5,8 @@ "description": "OpenUI5 TypeScript Walkthrough: Step 10 - Descriptor for Applications", "private": true, "scripts": { - "start": "ui5 serve -o index.html" + "start": "ui5 serve -o index.html", + "typecheck": "tsc --noEmit" }, "devDependencies": { "@types/openui5": "^1.146.0", diff --git a/packages/walkthrough/steps/10/webapp/controller/App.controller.ts b/packages/walkthrough/steps/10/webapp/controller/App.controller.ts index d5342a470..6b3072be1 100644 --- a/packages/walkthrough/steps/10/webapp/controller/App.controller.ts +++ b/packages/walkthrough/steps/10/webapp/controller/App.controller.ts @@ -12,7 +12,7 @@ export default class AppController extends Controller { // read msg from i18n model const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name"); const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle; - const msg = resourceBundle.getText("helloMsg", [recipient]); + const msg = resourceBundle.getText("helloMsg", [recipient]) as string; // show message MessageToast.show(msg); } diff --git a/packages/walkthrough/steps/11/package.json b/packages/walkthrough/steps/11/package.json index d520eb49b..ae4160298 100644 --- a/packages/walkthrough/steps/11/package.json +++ b/packages/walkthrough/steps/11/package.json @@ -5,7 +5,8 @@ "description": "OpenUI5 TypeScript Walkthrough: Step 11 - Pages and Panels", "private": true, "scripts": { - "start": "ui5 serve -o index.html" + "start": "ui5 serve -o index.html", + "typecheck": "tsc --noEmit" }, "devDependencies": { "@types/openui5": "^1.146.0", diff --git a/packages/walkthrough/steps/11/webapp/controller/App.controller.ts b/packages/walkthrough/steps/11/webapp/controller/App.controller.ts index d5342a470..6b3072be1 100644 --- a/packages/walkthrough/steps/11/webapp/controller/App.controller.ts +++ b/packages/walkthrough/steps/11/webapp/controller/App.controller.ts @@ -12,7 +12,7 @@ export default class AppController extends Controller { // read msg from i18n model const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name"); const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle; - const msg = resourceBundle.getText("helloMsg", [recipient]); + const msg = resourceBundle.getText("helloMsg", [recipient]) as string; // show message MessageToast.show(msg); } diff --git a/packages/walkthrough/steps/12/package.json b/packages/walkthrough/steps/12/package.json index 1449a5441..3f1500590 100644 --- a/packages/walkthrough/steps/12/package.json +++ b/packages/walkthrough/steps/12/package.json @@ -5,7 +5,8 @@ "description": "OpenUI5 TypeScript Walkthrough: Step 12 - Shell Control as Container", "private": true, "scripts": { - "start": "ui5 serve -o index.html" + "start": "ui5 serve -o index.html", + "typecheck": "tsc --noEmit" }, "devDependencies": { "@types/openui5": "^1.146.0", diff --git a/packages/walkthrough/steps/12/webapp/controller/App.controller.ts b/packages/walkthrough/steps/12/webapp/controller/App.controller.ts index d5342a470..6b3072be1 100644 --- a/packages/walkthrough/steps/12/webapp/controller/App.controller.ts +++ b/packages/walkthrough/steps/12/webapp/controller/App.controller.ts @@ -12,7 +12,7 @@ export default class AppController extends Controller { // read msg from i18n model const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name"); const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle; - const msg = resourceBundle.getText("helloMsg", [recipient]); + const msg = resourceBundle.getText("helloMsg", [recipient]) as string; // show message MessageToast.show(msg); } diff --git a/packages/walkthrough/steps/13/package.json b/packages/walkthrough/steps/13/package.json index 488119af5..94bb4ea84 100644 --- a/packages/walkthrough/steps/13/package.json +++ b/packages/walkthrough/steps/13/package.json @@ -5,7 +5,8 @@ "description": "OpenUI5 TypeScript Walkthrough: Step 13 - Margins and Paddings", "private": true, "scripts": { - "start": "ui5 serve -o index.html" + "start": "ui5 serve -o index.html", + "typecheck": "tsc --noEmit" }, "devDependencies": { "@types/openui5": "^1.146.0", diff --git a/packages/walkthrough/steps/13/webapp/controller/App.controller.ts b/packages/walkthrough/steps/13/webapp/controller/App.controller.ts index d5342a470..6b3072be1 100644 --- a/packages/walkthrough/steps/13/webapp/controller/App.controller.ts +++ b/packages/walkthrough/steps/13/webapp/controller/App.controller.ts @@ -12,7 +12,7 @@ export default class AppController extends Controller { // read msg from i18n model const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name"); const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle; - const msg = resourceBundle.getText("helloMsg", [recipient]); + const msg = resourceBundle.getText("helloMsg", [recipient]) as string; // show message MessageToast.show(msg); } diff --git a/packages/walkthrough/steps/14/package.json b/packages/walkthrough/steps/14/package.json index 21e4912de..1e8b6356b 100644 --- a/packages/walkthrough/steps/14/package.json +++ b/packages/walkthrough/steps/14/package.json @@ -5,7 +5,8 @@ "description": "OpenUI5 TypeScript Walkthrough: Step 14 - Custom CSS and Theme Colors", "private": true, "scripts": { - "start": "ui5 serve -o index.html" + "start": "ui5 serve -o index.html", + "typecheck": "tsc --noEmit" }, "devDependencies": { "@types/openui5": "^1.146.0", diff --git a/packages/walkthrough/steps/14/webapp/controller/App.controller.ts b/packages/walkthrough/steps/14/webapp/controller/App.controller.ts index d5342a470..6b3072be1 100644 --- a/packages/walkthrough/steps/14/webapp/controller/App.controller.ts +++ b/packages/walkthrough/steps/14/webapp/controller/App.controller.ts @@ -12,7 +12,7 @@ export default class AppController extends Controller { // read msg from i18n model const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name"); const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle; - const msg = resourceBundle.getText("helloMsg", [recipient]); + const msg = resourceBundle.getText("helloMsg", [recipient]) as string; // show message MessageToast.show(msg); } diff --git a/packages/walkthrough/steps/15/README.md b/packages/walkthrough/steps/15/README.md index 9b9561365..6934e267f 100644 --- a/packages/walkthrough/steps/15/README.md +++ b/packages/walkthrough/steps/15/README.md @@ -53,7 +53,7 @@ export default class HelloPanel extends Controller { // functions with generic return values require casting const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle; const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name"); - const msg = resourceBundle.getText("helloMsg", [recipient]); + const msg = resourceBundle.getText("helloMsg", [recipient]) as string; // show message MessageToast.show(msg); } @@ -70,7 +70,7 @@ sap.ui.define(["sap/ui/core/mvc/Controller", "sap/m/MessageToast"], function (Co // read msg from i18n model const recipient = this.getView()?.getModel()?.getProperty("/recipient/name"); const resourceBundle = this.getView()?.getModel("i18n")?.getResourceBundle(); - const msg = resourceBundle.getText("helloMsg", [recipient]); + const msg = resourceBundle.getText("helloMsg", [recipient]) as string; // show message MessageToast.show(msg); } diff --git a/packages/walkthrough/steps/15/package.json b/packages/walkthrough/steps/15/package.json index 4bc04ffdd..46a83e839 100644 --- a/packages/walkthrough/steps/15/package.json +++ b/packages/walkthrough/steps/15/package.json @@ -5,7 +5,8 @@ "description": "OpenUI5 TypeScript Walkthrough: Step 15 - Nested Views", "private": true, "scripts": { - "start": "ui5 serve -o index.html" + "start": "ui5 serve -o index.html", + "typecheck": "tsc --noEmit" }, "devDependencies": { "@types/openui5": "^1.146.0", diff --git a/packages/walkthrough/steps/15/webapp/controller/HelloPanel.controller.ts b/packages/walkthrough/steps/15/webapp/controller/HelloPanel.controller.ts index 9df486f2d..9e6a761f5 100644 --- a/packages/walkthrough/steps/15/webapp/controller/HelloPanel.controller.ts +++ b/packages/walkthrough/steps/15/webapp/controller/HelloPanel.controller.ts @@ -13,7 +13,7 @@ export default class HelloPanel extends Controller { // read msg from i18n model const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name"); const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle; - const msg = resourceBundle.getText("helloMsg", [recipient]); + const msg = resourceBundle.getText("helloMsg", [recipient]) as string; // show message MessageToast.show(msg); } diff --git a/packages/walkthrough/steps/16/package.json b/packages/walkthrough/steps/16/package.json index 7adc0663e..fb1fb2d93 100644 --- a/packages/walkthrough/steps/16/package.json +++ b/packages/walkthrough/steps/16/package.json @@ -5,7 +5,8 @@ "description": "OpenUI5 TypeScript Walkthrough: Step 16 - Dialogs and Fragments", "private": true, "scripts": { - "start": "ui5 serve -o index.html" + "start": "ui5 serve -o index.html", + "typecheck": "tsc --noEmit" }, "devDependencies": { "@types/openui5": "^1.146.0", diff --git a/packages/walkthrough/steps/16/webapp/controller/HelloPanel.controller.ts b/packages/walkthrough/steps/16/webapp/controller/HelloPanel.controller.ts index 132f65b72..007293a1e 100644 --- a/packages/walkthrough/steps/16/webapp/controller/HelloPanel.controller.ts +++ b/packages/walkthrough/steps/16/webapp/controller/HelloPanel.controller.ts @@ -14,7 +14,7 @@ export default class HelloPanel extends Controller { // read msg from i18n model const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name"); const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle; - const msg = resourceBundle.getText("helloMsg", [recipient]); + const msg = resourceBundle.getText("helloMsg", [recipient]) as string; // show message MessageToast.show(msg); } diff --git a/packages/walkthrough/steps/17/README.md b/packages/walkthrough/steps/17/README.md index 341de74b5..52ae0655e 100644 --- a/packages/walkthrough/steps/17/README.md +++ b/packages/walkthrough/steps/17/README.md @@ -51,7 +51,7 @@ export default class HelloPanel extends Controller { // read msg from i18n model const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name"); const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle; - const msg = resourceBundle.getText("helloMsg", [recipient]); + const msg = resourceBundle.getText("helloMsg", [recipient]) as string; // show message MessageToast.show(msg); } @@ -77,7 +77,7 @@ sap.ui.define(["sap/ui/core/mvc/Controller", "sap/m/MessageToast"], function (Co // read msg from i18n model const recipient = this.getView()?.getModel()?.getProperty("/recipient/name"); const resourceBundle = this.getView()?.getModel("i18n")?.getResourceBundle(); - const msg = resourceBundle.getText("helloMsg", [recipient]); + const msg = resourceBundle.getText("helloMsg", [recipient]) as string; // show message MessageToast.show(msg); }, diff --git a/packages/walkthrough/steps/17/package.json b/packages/walkthrough/steps/17/package.json index f5269b18f..7f8795fae 100644 --- a/packages/walkthrough/steps/17/package.json +++ b/packages/walkthrough/steps/17/package.json @@ -5,7 +5,8 @@ "description": "OpenUI5 TypeScript Walkthrough: Step 17 - Fragment Callbacks", "private": true, "scripts": { - "start": "ui5 serve -o index.html" + "start": "ui5 serve -o index.html", + "typecheck": "tsc --noEmit" }, "devDependencies": { "@types/openui5": "^1.146.0", diff --git a/packages/walkthrough/steps/17/webapp/controller/HelloPanel.controller.ts b/packages/walkthrough/steps/17/webapp/controller/HelloPanel.controller.ts index 68c6fe500..2ff9e8c94 100644 --- a/packages/walkthrough/steps/17/webapp/controller/HelloPanel.controller.ts +++ b/packages/walkthrough/steps/17/webapp/controller/HelloPanel.controller.ts @@ -14,7 +14,7 @@ export default class HelloPanel extends Controller { // read msg from i18n model const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name"); const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle; - const msg = resourceBundle.getText("helloMsg", [recipient]); + const msg = resourceBundle.getText("helloMsg", [recipient]) as string; // show message MessageToast.show(msg); } diff --git a/packages/walkthrough/steps/18/package.json b/packages/walkthrough/steps/18/package.json index 356f2d336..fc1743df4 100644 --- a/packages/walkthrough/steps/18/package.json +++ b/packages/walkthrough/steps/18/package.json @@ -5,7 +5,8 @@ "description": "OpenUI5 TypeScript Walkthrough: Step 18 - Icons", "private": true, "scripts": { - "start": "ui5 serve -o index.html" + "start": "ui5 serve -o index.html", + "typecheck": "tsc --noEmit" }, "devDependencies": { "@types/openui5": "^1.146.0", diff --git a/packages/walkthrough/steps/18/webapp/controller/HelloPanel.controller.ts b/packages/walkthrough/steps/18/webapp/controller/HelloPanel.controller.ts index 9b8457831..333931030 100644 --- a/packages/walkthrough/steps/18/webapp/controller/HelloPanel.controller.ts +++ b/packages/walkthrough/steps/18/webapp/controller/HelloPanel.controller.ts @@ -14,7 +14,7 @@ export default class HelloPanel extends Controller { // read msg from i18n model const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name"); const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle; - const msg = resourceBundle.getText("helloMsg", [recipient]); + const msg = resourceBundle.getText("helloMsg", [recipient]) as string; // show message MessageToast.show(msg); } diff --git a/packages/walkthrough/steps/19/package.json b/packages/walkthrough/steps/19/package.json index 55872a2dc..86acb5b0a 100644 --- a/packages/walkthrough/steps/19/package.json +++ b/packages/walkthrough/steps/19/package.json @@ -5,7 +5,8 @@ "description": "OpenUI5 TypeScript Walkthrough: Step 19 - Aggregation Binding", "private": true, "scripts": { - "start": "ui5 serve -o index.html" + "start": "ui5 serve -o index.html", + "typecheck": "tsc --noEmit" }, "devDependencies": { "@types/openui5": "^1.146.0", diff --git a/packages/walkthrough/steps/19/webapp/controller/HelloPanel.controller.ts b/packages/walkthrough/steps/19/webapp/controller/HelloPanel.controller.ts index 9b8457831..333931030 100644 --- a/packages/walkthrough/steps/19/webapp/controller/HelloPanel.controller.ts +++ b/packages/walkthrough/steps/19/webapp/controller/HelloPanel.controller.ts @@ -14,7 +14,7 @@ export default class HelloPanel extends Controller { // read msg from i18n model const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name"); const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle; - const msg = resourceBundle.getText("helloMsg", [recipient]); + const msg = resourceBundle.getText("helloMsg", [recipient]) as string; // show message MessageToast.show(msg); } diff --git a/packages/walkthrough/steps/20/package.json b/packages/walkthrough/steps/20/package.json index cd8686d9c..e0163735e 100644 --- a/packages/walkthrough/steps/20/package.json +++ b/packages/walkthrough/steps/20/package.json @@ -5,7 +5,8 @@ "description": "OpenUI5 TypeScript Walkthrough: Step 20 - Data Types", "private": true, "scripts": { - "start": "ui5 serve -o index.html" + "start": "ui5 serve -o index.html", + "typecheck": "tsc --noEmit" }, "devDependencies": { "@types/openui5": "^1.146.0", diff --git a/packages/walkthrough/steps/20/webapp/controller/HelloPanel.controller.ts b/packages/walkthrough/steps/20/webapp/controller/HelloPanel.controller.ts index 9b8457831..333931030 100644 --- a/packages/walkthrough/steps/20/webapp/controller/HelloPanel.controller.ts +++ b/packages/walkthrough/steps/20/webapp/controller/HelloPanel.controller.ts @@ -14,7 +14,7 @@ export default class HelloPanel extends Controller { // read msg from i18n model const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name"); const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle; - const msg = resourceBundle.getText("helloMsg", [recipient]); + const msg = resourceBundle.getText("helloMsg", [recipient]) as string; // show message MessageToast.show(msg); } diff --git a/packages/walkthrough/steps/21/package.json b/packages/walkthrough/steps/21/package.json index bbe470a47..f6444755f 100644 --- a/packages/walkthrough/steps/21/package.json +++ b/packages/walkthrough/steps/21/package.json @@ -5,7 +5,8 @@ "description": "OpenUI5 TypeScript Walkthrough: Step 21 - Expression Binding", "private": true, "scripts": { - "start": "ui5 serve -o index.html" + "start": "ui5 serve -o index.html", + "typecheck": "tsc --noEmit" }, "devDependencies": { "@types/openui5": "^1.146.0", diff --git a/packages/walkthrough/steps/21/webapp/controller/HelloPanel.controller.ts b/packages/walkthrough/steps/21/webapp/controller/HelloPanel.controller.ts index 9b8457831..333931030 100644 --- a/packages/walkthrough/steps/21/webapp/controller/HelloPanel.controller.ts +++ b/packages/walkthrough/steps/21/webapp/controller/HelloPanel.controller.ts @@ -14,7 +14,7 @@ export default class HelloPanel extends Controller { // read msg from i18n model const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name"); const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle; - const msg = resourceBundle.getText("helloMsg", [recipient]); + const msg = resourceBundle.getText("helloMsg", [recipient]) as string; // show message MessageToast.show(msg); } diff --git a/packages/walkthrough/steps/22/package.json b/packages/walkthrough/steps/22/package.json index 3db9db6e1..afe6bacc4 100644 --- a/packages/walkthrough/steps/22/package.json +++ b/packages/walkthrough/steps/22/package.json @@ -5,7 +5,8 @@ "description": "OpenUI5 TypeScript Walkthrough: Step 22 - Custom Formatters", "private": true, "scripts": { - "start": "ui5 serve -o index.html" + "start": "ui5 serve -o index.html", + "typecheck": "tsc --noEmit" }, "devDependencies": { "@types/openui5": "^1.146.0", diff --git a/packages/walkthrough/steps/22/webapp/controller/HelloPanel.controller.ts b/packages/walkthrough/steps/22/webapp/controller/HelloPanel.controller.ts index 9b8457831..333931030 100644 --- a/packages/walkthrough/steps/22/webapp/controller/HelloPanel.controller.ts +++ b/packages/walkthrough/steps/22/webapp/controller/HelloPanel.controller.ts @@ -14,7 +14,7 @@ export default class HelloPanel extends Controller { // read msg from i18n model const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name"); const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle; - const msg = resourceBundle.getText("helloMsg", [recipient]); + const msg = resourceBundle.getText("helloMsg", [recipient]) as string; // show message MessageToast.show(msg); } diff --git a/packages/walkthrough/steps/23/package.json b/packages/walkthrough/steps/23/package.json index 29ba7eff2..043095d79 100644 --- a/packages/walkthrough/steps/23/package.json +++ b/packages/walkthrough/steps/23/package.json @@ -5,7 +5,8 @@ "description": "OpenUI5 TypeScript Walkthrough: Step 23 - Filtering", "private": true, "scripts": { - "start": "ui5 serve -o index.html" + "start": "ui5 serve -o index.html", + "typecheck": "tsc --noEmit" }, "devDependencies": { "@types/openui5": "^1.146.0", diff --git a/packages/walkthrough/steps/23/webapp/controller/HelloPanel.controller.ts b/packages/walkthrough/steps/23/webapp/controller/HelloPanel.controller.ts index 9b8457831..333931030 100644 --- a/packages/walkthrough/steps/23/webapp/controller/HelloPanel.controller.ts +++ b/packages/walkthrough/steps/23/webapp/controller/HelloPanel.controller.ts @@ -14,7 +14,7 @@ export default class HelloPanel extends Controller { // read msg from i18n model const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name"); const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle; - const msg = resourceBundle.getText("helloMsg", [recipient]); + const msg = resourceBundle.getText("helloMsg", [recipient]) as string; // show message MessageToast.show(msg); } diff --git a/packages/walkthrough/steps/24/package.json b/packages/walkthrough/steps/24/package.json index 1a7393c5f..8a8c5fc6b 100644 --- a/packages/walkthrough/steps/24/package.json +++ b/packages/walkthrough/steps/24/package.json @@ -5,7 +5,8 @@ "description": "OpenUI5 TypeScript Walkthrough: Step 24 - Sorting and Grouping", "private": true, "scripts": { - "start": "ui5 serve -o index.html" + "start": "ui5 serve -o index.html", + "typecheck": "tsc --noEmit" }, "devDependencies": { "@types/openui5": "^1.146.0", diff --git a/packages/walkthrough/steps/24/webapp/controller/HelloPanel.controller.ts b/packages/walkthrough/steps/24/webapp/controller/HelloPanel.controller.ts index 9b8457831..333931030 100644 --- a/packages/walkthrough/steps/24/webapp/controller/HelloPanel.controller.ts +++ b/packages/walkthrough/steps/24/webapp/controller/HelloPanel.controller.ts @@ -14,7 +14,7 @@ export default class HelloPanel extends Controller { // read msg from i18n model const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name"); const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle; - const msg = resourceBundle.getText("helloMsg", [recipient]); + const msg = resourceBundle.getText("helloMsg", [recipient]) as string; // show message MessageToast.show(msg); } diff --git a/packages/walkthrough/steps/25/package.json b/packages/walkthrough/steps/25/package.json index 9905831bd..6ca678cfa 100644 --- a/packages/walkthrough/steps/25/package.json +++ b/packages/walkthrough/steps/25/package.json @@ -5,7 +5,8 @@ "description": "OpenUI5 TypeScript Walkthrough: Step 25 - Remote OData Service", "private": true, "scripts": { - "start": "ui5 serve -o index.html" + "start": "ui5 serve -o index.html", + "typecheck": "tsc --noEmit" }, "devDependencies": { "@types/openui5": "^1.146.0", diff --git a/packages/walkthrough/steps/25/webapp/controller/HelloPanel.controller.ts b/packages/walkthrough/steps/25/webapp/controller/HelloPanel.controller.ts index 9b8457831..333931030 100644 --- a/packages/walkthrough/steps/25/webapp/controller/HelloPanel.controller.ts +++ b/packages/walkthrough/steps/25/webapp/controller/HelloPanel.controller.ts @@ -14,7 +14,7 @@ export default class HelloPanel extends Controller { // read msg from i18n model const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name"); const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle; - const msg = resourceBundle.getText("helloMsg", [recipient]); + const msg = resourceBundle.getText("helloMsg", [recipient]) as string; // show message MessageToast.show(msg); } diff --git a/packages/walkthrough/steps/26/package.json b/packages/walkthrough/steps/26/package.json index 5083bb9d6..4a39f1d89 100644 --- a/packages/walkthrough/steps/26/package.json +++ b/packages/walkthrough/steps/26/package.json @@ -5,7 +5,8 @@ "description": "OpenUI5 TypeScript Walkthrough: Step 26 - Mock Server Configuration", "private": true, "scripts": { - "start": "ui5 serve -o test/mockServer.html" + "start": "ui5 serve -o test/mockServer.html", + "typecheck": "tsc --noEmit" }, "devDependencies": { "@types/openui5": "^1.146.0", diff --git a/packages/walkthrough/steps/26/webapp/controller/HelloPanel.controller.ts b/packages/walkthrough/steps/26/webapp/controller/HelloPanel.controller.ts index 9b8457831..333931030 100644 --- a/packages/walkthrough/steps/26/webapp/controller/HelloPanel.controller.ts +++ b/packages/walkthrough/steps/26/webapp/controller/HelloPanel.controller.ts @@ -14,7 +14,7 @@ export default class HelloPanel extends Controller { // read msg from i18n model const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name"); const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle; - const msg = resourceBundle.getText("helloMsg", [recipient]); + const msg = resourceBundle.getText("helloMsg", [recipient]) as string; // show message MessageToast.show(msg); } diff --git a/packages/walkthrough/steps/27/package.json b/packages/walkthrough/steps/27/package.json index 7e95da3dc..269678a9d 100644 --- a/packages/walkthrough/steps/27/package.json +++ b/packages/walkthrough/steps/27/package.json @@ -5,7 +5,8 @@ "description": "OpenUI5 TypeScript Walkthrough: Step 27 - Unit Test with QUnit", "private": true, "scripts": { - "start": "ui5 serve -o test/mockServer.html" + "start": "ui5 serve -o test/mockServer.html", + "typecheck": "tsc --noEmit" }, "devDependencies": { "@types/openui5": "^1.146.0", diff --git a/packages/walkthrough/steps/27/webapp/controller/HelloPanel.controller.ts b/packages/walkthrough/steps/27/webapp/controller/HelloPanel.controller.ts index 9b8457831..333931030 100644 --- a/packages/walkthrough/steps/27/webapp/controller/HelloPanel.controller.ts +++ b/packages/walkthrough/steps/27/webapp/controller/HelloPanel.controller.ts @@ -14,7 +14,7 @@ export default class HelloPanel extends Controller { // read msg from i18n model const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name"); const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle; - const msg = resourceBundle.getText("helloMsg", [recipient]); + const msg = resourceBundle.getText("helloMsg", [recipient]) as string; // show message MessageToast.show(msg); } diff --git a/packages/walkthrough/steps/28/package.json b/packages/walkthrough/steps/28/package.json index 4edd51c79..ca0102f65 100644 --- a/packages/walkthrough/steps/28/package.json +++ b/packages/walkthrough/steps/28/package.json @@ -5,7 +5,8 @@ "description": "OpenUI5 TypeScript Walkthrough: Step 28 - Integration Test with OPA", "private": true, "scripts": { - "start": "ui5 serve -o test/mockServer.html" + "start": "ui5 serve -o test/mockServer.html", + "typecheck": "tsc --noEmit" }, "devDependencies": { "@types/openui5": "^1.146.0", diff --git a/packages/walkthrough/steps/28/webapp/controller/HelloPanel.controller.ts b/packages/walkthrough/steps/28/webapp/controller/HelloPanel.controller.ts index 9b8457831..333931030 100644 --- a/packages/walkthrough/steps/28/webapp/controller/HelloPanel.controller.ts +++ b/packages/walkthrough/steps/28/webapp/controller/HelloPanel.controller.ts @@ -14,7 +14,7 @@ export default class HelloPanel extends Controller { // read msg from i18n model const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name"); const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle; - const msg = resourceBundle.getText("helloMsg", [recipient]); + const msg = resourceBundle.getText("helloMsg", [recipient]) as string; // show message MessageToast.show(msg); } diff --git a/packages/walkthrough/steps/29/package.json b/packages/walkthrough/steps/29/package.json index 0dcd4cff0..c5793ecc1 100644 --- a/packages/walkthrough/steps/29/package.json +++ b/packages/walkthrough/steps/29/package.json @@ -5,7 +5,8 @@ "description": "OpenUI5 TypeScript Walkthrough: Step 29 - Debugging Tools", "private": true, "scripts": { - "start": "ui5 serve -o test/mockServer.html" + "start": "ui5 serve -o test/mockServer.html", + "typecheck": "tsc --noEmit" }, "devDependencies": { "@types/openui5": "^1.146.0", diff --git a/packages/walkthrough/steps/29/webapp/controller/HelloPanel.controller.ts b/packages/walkthrough/steps/29/webapp/controller/HelloPanel.controller.ts index 9b8457831..333931030 100644 --- a/packages/walkthrough/steps/29/webapp/controller/HelloPanel.controller.ts +++ b/packages/walkthrough/steps/29/webapp/controller/HelloPanel.controller.ts @@ -14,7 +14,7 @@ export default class HelloPanel extends Controller { // read msg from i18n model const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name"); const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle; - const msg = resourceBundle.getText("helloMsg", [recipient]); + const msg = resourceBundle.getText("helloMsg", [recipient]) as string; // show message MessageToast.show(msg); } diff --git a/packages/walkthrough/steps/30/package.json b/packages/walkthrough/steps/30/package.json index 99e2523e7..dab663b9c 100644 --- a/packages/walkthrough/steps/30/package.json +++ b/packages/walkthrough/steps/30/package.json @@ -5,7 +5,8 @@ "description": "OpenUI5 TypeScript Walkthrough: Step 30 - Routing and Navigation", "private": true, "scripts": { - "start": "ui5 serve -o test/mockServer.html" + "start": "ui5 serve -o test/mockServer.html", + "typecheck": "tsc --noEmit" }, "devDependencies": { "@types/openui5": "^1.146.0", diff --git a/packages/walkthrough/steps/30/webapp/controller/HelloPanel.controller.ts b/packages/walkthrough/steps/30/webapp/controller/HelloPanel.controller.ts index 9b8457831..333931030 100644 --- a/packages/walkthrough/steps/30/webapp/controller/HelloPanel.controller.ts +++ b/packages/walkthrough/steps/30/webapp/controller/HelloPanel.controller.ts @@ -14,7 +14,7 @@ export default class HelloPanel extends Controller { // read msg from i18n model const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name"); const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle; - const msg = resourceBundle.getText("helloMsg", [recipient]); + const msg = resourceBundle.getText("helloMsg", [recipient]) as string; // show message MessageToast.show(msg); } diff --git a/packages/walkthrough/steps/31/package.json b/packages/walkthrough/steps/31/package.json index 91994f1fd..3283a68fb 100644 --- a/packages/walkthrough/steps/31/package.json +++ b/packages/walkthrough/steps/31/package.json @@ -5,7 +5,8 @@ "description": "OpenUI5 TypeScript Walkthrough: Step 31 - Routing with Parameters", "private": true, "scripts": { - "start": "ui5 serve -o test/mockServer.html" + "start": "ui5 serve -o test/mockServer.html", + "typecheck": "tsc --noEmit" }, "devDependencies": { "@types/openui5": "^1.146.0", diff --git a/packages/walkthrough/steps/31/webapp/controller/HelloPanel.controller.ts b/packages/walkthrough/steps/31/webapp/controller/HelloPanel.controller.ts index 9b8457831..333931030 100644 --- a/packages/walkthrough/steps/31/webapp/controller/HelloPanel.controller.ts +++ b/packages/walkthrough/steps/31/webapp/controller/HelloPanel.controller.ts @@ -14,7 +14,7 @@ export default class HelloPanel extends Controller { // read msg from i18n model const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name"); const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle; - const msg = resourceBundle.getText("helloMsg", [recipient]); + const msg = resourceBundle.getText("helloMsg", [recipient]) as string; // show message MessageToast.show(msg); } diff --git a/packages/walkthrough/steps/32/package.json b/packages/walkthrough/steps/32/package.json index 714767eb5..9bd2d7f00 100644 --- a/packages/walkthrough/steps/32/package.json +++ b/packages/walkthrough/steps/32/package.json @@ -5,7 +5,8 @@ "description": "OpenUI5 TypeScript Walkthrough: Step 32 - Routing Back and History", "private": true, "scripts": { - "start": "ui5 serve -o test/mockServer.html" + "start": "ui5 serve -o test/mockServer.html", + "typecheck": "tsc --noEmit" }, "devDependencies": { "@types/openui5": "^1.146.0", diff --git a/packages/walkthrough/steps/32/webapp/controller/HelloPanel.controller.ts b/packages/walkthrough/steps/32/webapp/controller/HelloPanel.controller.ts index 9b8457831..333931030 100644 --- a/packages/walkthrough/steps/32/webapp/controller/HelloPanel.controller.ts +++ b/packages/walkthrough/steps/32/webapp/controller/HelloPanel.controller.ts @@ -14,7 +14,7 @@ export default class HelloPanel extends Controller { // read msg from i18n model const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name"); const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle; - const msg = resourceBundle.getText("helloMsg", [recipient]); + const msg = resourceBundle.getText("helloMsg", [recipient]) as string; // show message MessageToast.show(msg); } diff --git a/packages/walkthrough/steps/33/package.json b/packages/walkthrough/steps/33/package.json index 42399cb30..c633c13ca 100644 --- a/packages/walkthrough/steps/33/package.json +++ b/packages/walkthrough/steps/33/package.json @@ -5,7 +5,8 @@ "description": "OpenUI5 TypeScript Walkthrough: Step 33 - Custom Controls", "private": true, "scripts": { - "start": "ui5 serve -o test/mockServer.html" + "start": "ui5 serve -o test/mockServer.html", + "typecheck": "tsc --noEmit" }, "devDependencies": { "@types/openui5": "^1.146.0", diff --git a/packages/walkthrough/steps/33/webapp/controller/HelloPanel.controller.ts b/packages/walkthrough/steps/33/webapp/controller/HelloPanel.controller.ts index 9b8457831..333931030 100644 --- a/packages/walkthrough/steps/33/webapp/controller/HelloPanel.controller.ts +++ b/packages/walkthrough/steps/33/webapp/controller/HelloPanel.controller.ts @@ -14,7 +14,7 @@ export default class HelloPanel extends Controller { // read msg from i18n model const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name"); const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle; - const msg = resourceBundle.getText("helloMsg", [recipient]); + const msg = resourceBundle.getText("helloMsg", [recipient]) as string; // show message MessageToast.show(msg); } diff --git a/packages/walkthrough/steps/34/package.json b/packages/walkthrough/steps/34/package.json index b724850af..a52bfc5ed 100644 --- a/packages/walkthrough/steps/34/package.json +++ b/packages/walkthrough/steps/34/package.json @@ -5,7 +5,8 @@ "description": "OpenUI5 TypeScript Walkthrough: Step 34 - Responsiveness", "private": true, "scripts": { - "start": "ui5 serve -o test/mockServer.html" + "start": "ui5 serve -o test/mockServer.html", + "typecheck": "tsc --noEmit" }, "devDependencies": { "@types/openui5": "^1.146.0", diff --git a/packages/walkthrough/steps/34/webapp/controller/HelloPanel.controller.ts b/packages/walkthrough/steps/34/webapp/controller/HelloPanel.controller.ts index 9b8457831..333931030 100644 --- a/packages/walkthrough/steps/34/webapp/controller/HelloPanel.controller.ts +++ b/packages/walkthrough/steps/34/webapp/controller/HelloPanel.controller.ts @@ -14,7 +14,7 @@ export default class HelloPanel extends Controller { // read msg from i18n model const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name"); const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle; - const msg = resourceBundle.getText("helloMsg", [recipient]); + const msg = resourceBundle.getText("helloMsg", [recipient]) as string; // show message MessageToast.show(msg); } diff --git a/packages/walkthrough/steps/35/package.json b/packages/walkthrough/steps/35/package.json index bb3636534..3124920eb 100644 --- a/packages/walkthrough/steps/35/package.json +++ b/packages/walkthrough/steps/35/package.json @@ -5,7 +5,8 @@ "description": "OpenUI5 TypeScript Walkthrough: Step 35 - Device Adaptation", "private": true, "scripts": { - "start": "ui5 serve -o test/mockServer.html" + "start": "ui5 serve -o test/mockServer.html", + "typecheck": "tsc --noEmit" }, "devDependencies": { "@types/openui5": "^1.146.0", diff --git a/packages/walkthrough/steps/35/webapp/controller/HelloPanel.controller.ts b/packages/walkthrough/steps/35/webapp/controller/HelloPanel.controller.ts index 9b8457831..333931030 100644 --- a/packages/walkthrough/steps/35/webapp/controller/HelloPanel.controller.ts +++ b/packages/walkthrough/steps/35/webapp/controller/HelloPanel.controller.ts @@ -14,7 +14,7 @@ export default class HelloPanel extends Controller { // read msg from i18n model const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name"); const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle; - const msg = resourceBundle.getText("helloMsg", [recipient]); + const msg = resourceBundle.getText("helloMsg", [recipient]) as string; // show message MessageToast.show(msg); } diff --git a/packages/walkthrough/steps/36/package.json b/packages/walkthrough/steps/36/package.json index 3a4d7f3f1..3362c00c8 100644 --- a/packages/walkthrough/steps/36/package.json +++ b/packages/walkthrough/steps/36/package.json @@ -5,7 +5,8 @@ "description": "OpenUI5 TypeScript Walkthrough: Step 36 - Content Density", "private": true, "scripts": { - "start": "ui5 serve -o test/mockServer.html" + "start": "ui5 serve -o test/mockServer.html", + "typecheck": "tsc --noEmit" }, "devDependencies": { "@types/openui5": "^1.146.0", diff --git a/packages/walkthrough/steps/36/webapp/controller/HelloPanel.controller.ts b/packages/walkthrough/steps/36/webapp/controller/HelloPanel.controller.ts index 9b8457831..333931030 100644 --- a/packages/walkthrough/steps/36/webapp/controller/HelloPanel.controller.ts +++ b/packages/walkthrough/steps/36/webapp/controller/HelloPanel.controller.ts @@ -14,7 +14,7 @@ export default class HelloPanel extends Controller { // read msg from i18n model const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name"); const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle; - const msg = resourceBundle.getText("helloMsg", [recipient]); + const msg = resourceBundle.getText("helloMsg", [recipient]) as string; // show message MessageToast.show(msg); } diff --git a/packages/walkthrough/steps/37/package.json b/packages/walkthrough/steps/37/package.json index ae496917c..e3552f776 100644 --- a/packages/walkthrough/steps/37/package.json +++ b/packages/walkthrough/steps/37/package.json @@ -5,7 +5,8 @@ "description": "OpenUI5 TypeScript Walkthrough: Step 37 - Accessibility", "private": true, "scripts": { - "start": "ui5 serve -o test/mockServer.html" + "start": "ui5 serve -o test/mockServer.html", + "typecheck": "tsc --noEmit" }, "devDependencies": { "@types/openui5": "^1.146.0", diff --git a/packages/walkthrough/steps/37/webapp/controller/HelloPanel.controller.ts b/packages/walkthrough/steps/37/webapp/controller/HelloPanel.controller.ts index 9b8457831..333931030 100644 --- a/packages/walkthrough/steps/37/webapp/controller/HelloPanel.controller.ts +++ b/packages/walkthrough/steps/37/webapp/controller/HelloPanel.controller.ts @@ -14,7 +14,7 @@ export default class HelloPanel extends Controller { // read msg from i18n model const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name"); const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle; - const msg = resourceBundle.getText("helloMsg", [recipient]); + const msg = resourceBundle.getText("helloMsg", [recipient]) as string; // show message MessageToast.show(msg); } diff --git a/packages/walkthrough/steps/38/package.json b/packages/walkthrough/steps/38/package.json index db806573a..2332677d7 100644 --- a/packages/walkthrough/steps/38/package.json +++ b/packages/walkthrough/steps/38/package.json @@ -7,7 +7,8 @@ "scripts": { "start": "ui5 serve -o test/mockServer.html", "build": "ui5 build --all --clean-dest", - "serve-dist": "ws --compress -d dist --open" + "serve-dist": "ws --compress -d dist --open", + "typecheck": "tsc --noEmit" }, "devDependencies": { "@types/openui5": "^1.146.0", diff --git a/packages/walkthrough/steps/38/webapp/controller/HelloPanel.controller.ts b/packages/walkthrough/steps/38/webapp/controller/HelloPanel.controller.ts index 9b8457831..333931030 100644 --- a/packages/walkthrough/steps/38/webapp/controller/HelloPanel.controller.ts +++ b/packages/walkthrough/steps/38/webapp/controller/HelloPanel.controller.ts @@ -14,7 +14,7 @@ export default class HelloPanel extends Controller { // read msg from i18n model const recipient = (this.getView()?.getModel() as JSONModel)?.getProperty("/recipient/name"); const resourceBundle = (this.getView()?.getModel("i18n") as ResourceModel)?.getResourceBundle() as ResourceBundle; - const msg = resourceBundle.getText("helloMsg", [recipient]); + const msg = resourceBundle.getText("helloMsg", [recipient]) as string; // show message MessageToast.show(msg); }